Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Variable organization in Mode URL #293

Merged
merged 1 commit into from
Jun 17, 2020
Merged

fix: Variable organization in Mode URL #293

merged 1 commit into from
Jun 17, 2020

Conversation

arjunlandes
Copy link
Contributor

@arjunlandes arjunlandes commented Jun 17, 2020

Summary of Changes

Change the Mode dashboard URL based on organization name passed in the config.

Tests

None, I didn't see tests for dashboards yet.

Documentation

None

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

The Mode dashboard URL should change based on organization name passed in the config.
@arjunlandes arjunlandes changed the title Variable organization in Model URL #fix Variable organization in Model URL Jun 17, 2020
@arjunlandes arjunlandes changed the title #fix Variable organization in Model URL fix: Variable organization in Model URL Jun 17, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2020

Codecov Report

Merging #293 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #293   +/-   ##
=======================================
  Coverage   73.67%   73.67%           
=======================================
  Files         101      101           
  Lines        4288     4288           
  Branches      399      399           
=======================================
  Hits         3159     3159           
  Misses       1029     1029           
  Partials      100      100           
Impacted Files Coverage Δ
...shboard/mode_analytics/mode_dashboard_extractor.py 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de2a9e1...a5ee5e2. Read the comment docs.

@arjunlandes arjunlandes changed the title fix: Variable organization in Model URL fix: Variable organization in Mode URL Jun 17, 2020
@feng-tao feng-tao merged commit b4c24ef into amundsen-io:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants