Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix invalid timestamp handling in dashboard transformer #339

Merged
merged 4 commits into from
Aug 20, 2020

Conversation

feng-tao
Copy link
Member

@feng-tao feng-tao commented Aug 19, 2020

Signed-off-by: feng-tao fengtao04@gmail.com

Summary of Changes

  1. handle invalid timestamp in transformer
  2. the dashboard-table model regex match should be relaxed to match more cases.
  3. Update version

Tests

Unit test added

Documentation

What documentation did you add or modify and why? Add any relevant links then remove this line

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

Signed-off-by: feng-tao <fengtao04@gmail.com>
Signed-off-by: feng-tao <fengtao04@gmail.com>
Signed-off-by: feng-tao <fengtao04@gmail.com>
jinhyukchang
jinhyukchang previously approved these changes Aug 19, 2020
Copy link
Contributor

@jinhyukchang jinhyukchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Signed-off-by: Tao Feng <fengtao04@gmail.com>
@feng-tao feng-tao dismissed stale reviews from dikshathakur3119 and jinhyukchang via 6a8437d August 20, 2020 05:16
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@feng-tao feng-tao merged commit 030ef49 into master Aug 20, 2020
@feng-tao feng-tao deleted the tfeng_fix_mode_dashboard branch August 20, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants