Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set Tableau URLs (base + API) via config #349

Merged
merged 4 commits into from
Aug 27, 2020

Conversation

alevene
Copy link
Contributor

@alevene alevene commented Aug 27, 2020

Summary of Changes

When executing the Tableau extractor in different environments (development, production, etc), we saw the need to have different URLs and protocols depending on connectivity. For example, our airflow server that runs the extractor routes to the Tableau server via port 80 and a specific IP address.
To allow for the most configurability, this PR opens up 2 values:

  • API_BASE_URL - Protocol+Host for API calls
  • TABLEAU_BASE_URL - Protocol+Host for links on the Dashboard Detail page (eg. "Open Dashboard" button)

TABLEAU_HOST has been removed in favor of these.

Tests

Added new configs to tests.

Documentation

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

Signed-off-by: Alex Levene <alex.levene@gusto.com>
Signed-off-by: Alex Levene <alex.levene@gusto.com>
Signed-off-by: Alex Levene <alex.levene@gusto.com>
Signed-off-by: Alex Levene <alex.levene@gusto.com>
@alevene alevene marked this pull request as ready for review August 27, 2020 20:26
Copy link
Member

@feng-tao feng-tao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@feng-tao feng-tao merged commit 1baec33 into amundsen-io:master Aug 27, 2020
@alevene alevene deleted the c/tableau-base-url branch October 7, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants