feat: Add config key for connect_arg for SqlAlchemyExtractor #434
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
I added a config key for the
SQLAlchemyExtractor
that lets the user specify generalconnect_args
for thesqlalchemy.create_engine
function. I did this because I want to use theSQLAlchemyExtractor
for Presto and I have an https connection so I need to pass the kwargconnect_args={"protocol": "https"}
intocreate_engine
.Tests
I added the test: test_get_connection in tests/unit/extractor/test_sql_alchemy_extractor.py
Documentation
I did not add any documentation
CheckList
Make sure you have checked all steps below to ensure a timely review.
make test