Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reconcile gremlin description writes with the Databuilder #290

Merged
merged 2 commits into from
Apr 12, 2021

Conversation

AndrewCiambrone
Copy link
Contributor

@AndrewCiambrone AndrewCiambrone commented Apr 12, 2021

Signed-off-by: Andrew Ciambrone andrjc4@vt.edu

Summary of Changes

  • Upgrades the metadata proxy requirements so that it uses amundsengremlin 0.0.9 which changes the description key to the same as the databuilders.

  • Removed the reset shards from the neptune proxy because that has been moved to amundsengremlin in 0.0.8

  • fixed the default source to be "description" instead of "user"

Tests

What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line

Documentation

What documentation did you add or modify and why? Add any relevant links then remove this line

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

Signed-off-by: Andrew Ciambrone <andrjc4@vt.edu>
Signed-off-by: Andrew Ciambrone <andrjc4@vt.edu>
@@ -123,6 +123,7 @@ class NeptuneConfig(LocalGremlinConfig, LocalConfig):
LOG_LEVEL = 'INFO'

# PROXY_HOST FORMAT: wss://<NEPTUNE_URL>:<NEPTUNE_PORT>/gremlin
PROXY_HOST = os.environ.get('PROXY_HOST', 'localhost')
Copy link
Contributor Author

@AndrewCiambrone AndrewCiambrone Apr 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was accidentally removed in #279. Adding it back in.

@feng-tao feng-tao merged commit 18454fe into amundsen-io:master Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants