Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close http client correctly #26

Merged
merged 2 commits into from
Nov 17, 2021
Merged

Close http client correctly #26

merged 2 commits into from
Nov 17, 2021

Conversation

tachyonics
Copy link
Contributor

@tachyonics tachyonics commented Nov 16, 2021 •
edited
Loading

Issue #, if available:

Description of changes:

  1. Correctly close http client
  2. Correctly create the credentials endpoint
  3. Move CI to Github actions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tachyonics tachyonics merged commit 7c00b2c into main Nov 17, 2021
@tachyonics tachyonics deleted the close_http_client branch November 17, 2021 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Gearou Josh-Gearou Josh-Gearou approved these changes

@jwenzhon jwenzhon jwenzhon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tachyonics @jwenzhon @Josh-Gearou