Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Dialer and Listener for WebRTC connections #384

Closed
anacrolix opened this issue Mar 19, 2020 · 4 comments
Closed

Implement Dialer and Listener for WebRTC connections #384

anacrolix opened this issue Mar 19, 2020 · 4 comments
Labels
enhancement help wanted question

Comments

@anacrolix
Copy link
Owner

anacrolix commented Mar 19, 2020 •
edited
Loading

Useful background information:
@anacrolix anacrolix added this to the webtorrent-support milestone Mar 19, 2020
@anacrolix
Copy link
Owner Author

anacrolix commented Mar 19, 2020 •
edited
Loading

The first step here would be to determine that WebRTC can be abstracted inside the Dialer and Listener interfaces appropriately. Particularly that the addr string in Dialer.Dial is sufficient. I'm also not sure that Listener is appropriate, I can figure that out with some time. Anyone that is more familiar with WebRTC is welcome to start on this. I'll assign it to myself if I start on it.

@anacrolix anacrolix self-assigned this Apr 7, 2020
@anacrolix
Copy link
Owner Author

After more investigation, I don't think the Dialer or Listener models work with WebRTC, at least not in the way I envisaged them. It might be possible via @backkem's suggestions at #138 (comment).

@anacrolix
Copy link
Owner Author

This might be a potential improvement, but isn't a blocker anymore.

@anacrolix anacrolix removed this from the webtorrent-support milestone Apr 13, 2020
@anacrolix anacrolix assigned anacrolix and unassigned anacrolix Apr 13, 2020
@anacrolix
Copy link
Owner Author

I have no intention to implement this, it can be reopened if it makes sense down the track.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anacrolix