Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the dependency on s3fs #3

Closed
LinusU opened this issue Aug 10, 2015 · 1 comment · Fixed by #8
Closed

Drop the dependency on s3fs #3

LinusU opened this issue Aug 10, 2015 · 1 comment · Fixed by #8

Comments

@LinusU
Copy link
Collaborator

LinusU commented Aug 10, 2015

I think it would be a good improvement to drop the dependency on s3fs and instead use aws-sdk directly. This would save the extra dependencies and give us access to upstream updates quicker.

I would be happy to provide the code if no one beats me to it.

On a related note, it seems like uploading to s3 from multer is very popular. How would you feel about getting some help on maintaining this module? I would personally be happy to hop on as a maintainer. Since it's such a small module I think the most work would be to cut new releases when dependencies (probably only aws-sdk) updates, and to answer questions from users.

I'm linusu on npm 😄

@anacronw
Copy link
Owner

I'd love help on this module! The only real value I added was making sure the integration worked - the rest was trivial yet I didn't see other modules doing the same thing. I don't have much time myself on open source unfortunately.

I'd be happy to take any pull requests. I can also add you as a maintainer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants