Update ad469x spi engine #1181
Merged
Update ad469x spi engine #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PIoandan
requested review from
PopPaul2021,
acostina and
AndreiGrozav
as code owners
PIoandan
force-pushed
the
update_ad469x_spi_engine
branch
from
bc425a1
to
c2e4dbf
Compare
gastmaier
reviewed
Sep 26, 2023
PIoandan
force-pushed
the
update_ad469x_spi_engine
branch
from
c2e4dbf
to
42d731a
Compare
gastmaier
previously approved these changes
Sep 27, 2023
IuliaCMoldovan
requested changes
Sep 28, 2023
I replaced the SPI Engine connections in the ad469x_bd.tcl with the spi_engine_create procedure found in the spi_engine.tcl script. Through these changes, a more generic instantiation for the spi_engine can be achieved. I also created the ad469x_fmc.txt file for generating the system_constr.xdc file. Signed-off-by: Ioan-daniel Pop <Pop.Ioan-daniel@analog.com>
The system_constr.xdc file is made based on the fmc_constr.xdc file generated by the adi_fmc_constr_generator.tcl script. Signed-off-by: Ioan-daniel Pop <Pop.Ioan-daniel@analog.com>
PIoandan
force-pushed
the
update_ad469x_spi_engine
branch
from
2e6b90e
to
eb34def
Compare
I modified the Readme.md file Signed-off-by: Ioan-daniel Pop <Pop.Ioan-daniel@analog.com>
PopPaul2021
requested changes
Oct 2, 2023
projects/ad469x_fmc/Readme.md
Outdated
| * Parts : [AD4696, 16-Bit, 16-Channel, 1 MSPS, Easy Drive Multiplexed SAR ADC](https://www.analog.com/ad4696) | ||
| * Parts : [AD4695, 16-Bit, 16-Channel, 500 kSPS, Easy Drive Multiplexed SAR ADC](https://www.analog.com/ad4695) | ||
| * Parts : [AD4697, 16-Bit, 8-Channel, 500 kSPS, Easy Drive Multiplexed SAR ADC](https://www.analog.com/ad4697) | ||
| * Parts : [AD4696, 16-Bit, 8-Channel, 1 MSPS, Easy Drive Multiplexed SAR ADC](https://www.analog.com/ad4696) |
There was a problem hiding this comment.
AD4696 appears to be duplicated, can you please remove it?
There was a problem hiding this comment.
Done. The last part must be ad4698.
Regenerated the Makefile and updated the Readme.md file. Signed-off-by: Ioan-daniel Pop <Pop.Ioan-daniel@analog.com>
I edited the ad469x_fmc.txt file. Signed-off-by: Ioan-daniel Pop <Pop.Ioan-daniel@analog.com>
gastmaier
approved these changes
Oct 10, 2023
PopPaul2021
approved these changes
Oct 19, 2023
acostina
approved these changes
Oct 24, 2023
IuliaCMoldovan
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
I replaced the SPI Engine connections in the ad469x_bd.tcl with the
spi_engine_create procedure found in the spi_engine.tcl script. Through
these changes, a more generic instantiation for the spi_engine can be
achieved. I also created the ad469x_fmc.txt file for generating the system_constr.xdc file.
Linux part works partially. Tested with NO-OS and it does not work.
PR Type
PR Checklist