Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set root property to empty string for new Analog projects #1474

Closed
2 tasks
brandonroberts opened this issue Dec 5, 2024 · 0 comments · Fixed by #1481
Closed
2 tasks

Set root property to empty string for new Analog projects #1474

brandonroberts opened this issue Dec 5, 2024 · 0 comments · Fixed by #1481
Labels
accepting PRs enhancement New feature or request

Comments

@brandonroberts
Copy link
Member

Which scope/s are relevant/related to the feature request?

create-analog

Information

When generating a new application with npm create analog@latest the angular.json contains a root property set to .. This was needed previously to resolve the vite config properly for ESM support. This is no longer needed and can be removed.

It also enables the ng lint command to run successfully to set up ESLint on an Analog project.

The template files are below:

https://github.com/analogjs/analog/blob/beta/packages/create-analog/template-minimal/angular.json#L8
https://github.com/analogjs/analog/blob/beta/packages/create-analog/template-latest/angular.json#L8
https://github.com/analogjs/analog/blob/beta/packages/create-analog/template-blog/angular.json#L8

Describe any alternatives/workarounds you're currently using

No response

I would be willing to submit a PR to fix this issue

  • Yes
  • No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting PRs enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant