-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checksum mismatches #472
Comments
Hi @paralin -- a couple things: First, as far as I can tell, there has not been a Secondly, cloning the
It sounds like you may need to clean your local cache or |
@kzantow Even with Also when removing the dirs manually:
Still this happens:
then
This is with If you don't set GOPROXY=direct, it will use the Go proxy for modules, which returns the correct hash. I agree it's a weird situation but the only two packages I am seeing this problem with are anchore/quill and anchore/go-macholibre |
I was able to work around the issue by forking both packages and adding replace directives. I assume next release the problem will go away. Its' vexing because the issue only happens with GOPROXY=direct and on MacOS (not linux). If anyone else runs into the same issue feel free to comment and I will reopen. |
Hey @paralin -- I missed a couple details: the |
I got the same checksum failure here even on my fork (which I didn't change anything on) (with a commit as the version in go.mod): https://github.com/aperturerobotics/bifrost/actions/runs/10212208324/job/28255061955#step:4:178 I think there is something about this repo which is causing it to hash differently on MacOS and Linux when the Go tool downloads it. It might be the symlinks to the test fixtures or something else. |
To test this, on macos:
Then on linux (with the same gomod): https://github.com/aperturerobotics/common/blob/58ef20f/tools/go.mod
Then I cd ~/go/pkg/mod/github.com/anchore/quill The two versions of the mod are uploaded:
I then went and diffed the two on a linux machine:
The differences:
When I compared the two, they seem to be substantially larger in the macos version:
Indeed you can see even the file sizes of the .tar.gz are different: -rw-r--r-- 1 cjs staff 760K Aug 2 01:33 quill-v0.4.2-linux.tar.gz |
When I dropped the test fixtures for both quill and go-macholibre it fixed the issue (different checksum on mac and linux). |
Does your fork of |
Yes, and I think the issue is not symlinks but rather the actual file contents inside text-fixtures, as shown above. |
Oh, I see these are both using |
@kzantow Thanks! |
fwiw i tried this on both mac and linux: # in goreleaser's src folder
go clean -modcache
sudo rm -rf $GOPATH/pkg/mod/github.com/anchore $GOPATH/pkg/sumdb
GOPROXY=direct go mod tidy and both worked fine... it seems there's another variable we're missing? fwiw go version 1.22.5, git version 2.45.2, git-lfs version 3.5.1, in my case, everything installed with nix on both OSs. |
I wonder if there's some git configuration that causes the LFS to have some different behavior. |
fwiw it seems I have the correct fixtures in my gopath: ❯ ls -lha --tree $GOPATH/pkg/mod/github.com/anchore/quill@v0.4.2/internal/test/test-fixtures/
dr-xr-xr-x carlos staff 288 B Tue Aug 13 09:40:04 2024 test-fixtures
.r--r--r-- carlos staff 0 B Tue Aug 13 09:40:04 2024 ├── .gitignore
dr-xr-xr-x carlos staff 960 B Tue Aug 13 09:40:04 2024 ├── assets
.r--r--r-- carlos staff 129 B Tue Aug 13 09:40:04 2024 │ ├── chain-ca-cert.pem
.r--r--r-- carlos staff 128 B Tue Aug 13 09:40:04 2024 │ ├── chain-ca-csr.pem
.r--r--r-- carlos staff 129 B Tue Aug 13 09:40:04 2024 │ ├── chain-ca-int-cert.pem
.r--r--r-- carlos staff 128 B Tue Aug 13 09:40:04 2024 │ ├── chain-ca-int-csr.pem
.r--r--r-- carlos staff 129 B Tue Aug 13 09:40:04 2024 │ ├── chain-ca-int-key.pem
.r--r--r-- carlos staff 129 B Tue Aug 13 09:40:04 2024 │ ├── chain-ca-key.pem
.r--r--r-- carlos staff 129 B Tue Aug 13 09:40:04 2024 │ ├── chain-leaf-cert.pem
.r--r--r-- carlos staff 129 B Tue Aug 13 09:40:04 2024 │ ├── chain-leaf-csr.pem
.r--r--r-- carlos staff 129 B Tue Aug 13 09:40:04 2024 │ ├── chain-leaf-key.pem
.r--r--r-- carlos staff 129 B Tue Aug 13 09:40:04 2024 │ ├── chain.p12
.r--r--r-- carlos staff 130 B Tue Aug 13 09:40:04 2024 │ ├── chain.pem
.r--r--r-- carlos staff 130 B Tue Aug 13 09:40:04 2024 │ ├── hello
.r--r--r-- carlos staff 129 B Tue Aug 13 09:40:04 2024 │ ├── hello-cert.pem
.r--r--r-- carlos staff 128 B Tue Aug 13 09:40:04 2024 │ ├── hello-config.ext
.r--r--r-- carlos staff 129 B Tue Aug 13 09:40:04 2024 │ ├── hello-key.pem
.r--r--r-- carlos staff 129 B Tue Aug 13 09:40:04 2024 │ ├── hello.p12
.r--r--r-- carlos staff 130 B Tue Aug 13 09:40:04 2024 │ ├── hello_adhoc_signed
.r--r--r-- carlos staff 130 B Tue Aug 13 09:40:04 2024 │ ├── hello_signed
.r--r--r-- carlos staff 131 B Tue Aug 13 09:40:04 2024 │ ├── ls_universal_signed
.r--r--r-- carlos staff 130 B Tue Aug 13 09:40:04 2024 │ ├── ls_x86_64_signed
.r--r--r-- carlos staff 133 B Tue Aug 13 09:40:04 2024 │ ├── syft_signed
.r--r--r-- carlos staff 133 B Tue Aug 13 09:40:04 2024 │ ├── syft_unsigned
.r--r--r-- carlos staff 133 B Tue Aug 13 09:40:04 2024 │ ├── syft_unsigned_arm64
.r--r--r-- carlos staff 129 B Tue Aug 13 09:40:04 2024 │ ├── x509-ca-cert.pem
.r--r--r-- carlos staff 129 B Tue Aug 13 09:40:04 2024 │ ├── x509-ca-key.pem
.r--r--r-- carlos staff 129 B Tue Aug 13 09:40:04 2024 │ ├── x509-cert.pem
.r--r--r-- carlos staff 128 B Tue Aug 13 09:40:04 2024 │ ├── x509-domain.ext
.r--r--r-- carlos staff 129 B Tue Aug 13 09:40:04 2024 │ └── x509-key.pem
dr-xr-xr-x carlos staff 416 B Tue Aug 13 09:40:04 2024 ├── fixture-chain
.r--r--r-- carlos staff 814 B Tue Aug 13 09:40:04 2024 │ ├── add-keychain.sh
.r--r--r-- carlos staff 533 B Tue Aug 13 09:40:04 2024 │ ├── ca.ext
.r--r--r-- carlos staff 896 B Tue Aug 13 09:40:04 2024 │ ├── intermediate.config
dr-xr-xr-x carlos staff 224 B Tue Aug 13 09:40:04 2024 │ ├── intermediate_ca
.r--r--r-- carlos staff 48 B Tue Aug 13 09:40:04 2024 │ │ ├── index
.r--r--r-- carlos staff 20 B Tue Aug 13 09:40:04 2024 │ │ ├── index.attr
.r--r--r-- carlos staff 0 B Tue Aug 13 09:40:04 2024 │ │ ├── index.old
.r--r--r-- carlos staff 3 B Tue Aug 13 09:40:04 2024 │ │ ├── serial
.r--r--r-- carlos staff 3 B Tue Aug 13 09:40:04 2024 │ │ └── serial.old
.r--r--r-- carlos staff 162 B Tue Aug 13 09:40:04 2024 │ ├── intermediate_req.config
.r--r--r-- carlos staff 501 B Tue Aug 13 09:40:04 2024 │ ├── leaf_req.config
.r--r--r-- carlos staff 6.0 KB Tue Aug 13 09:40:04 2024 │ ├── Makefile
.r--r--r-- carlos staff 849 B Tue Aug 13 09:40:04 2024 │ ├── root.config
dr-xr-xr-x carlos staff 256 B Tue Aug 13 09:40:04 2024 │ ├── root_ca
.r--r--r-- carlos staff 120 B Tue Aug 13 09:40:04 2024 │ │ ├── index
.r--r--r-- carlos staff 20 B Tue Aug 13 09:40:04 2024 │ │ ├── index.attr
.r--r--r-- carlos staff 20 B Tue Aug 13 09:40:04 2024 │ │ ├── index.attr.old
.r--r--r-- carlos staff 56 B Tue Aug 13 09:40:04 2024 │ │ ├── index.old
.r--r--r-- carlos staff 3 B Tue Aug 13 09:40:04 2024 │ │ ├── serial
.r--r--r-- carlos staff 3 B Tue Aug 13 09:40:04 2024 │ │ └── serial.old
.r--r--r-- carlos staff 154 B Tue Aug 13 09:40:04 2024 │ ├── root_req.config
dr-xr-xr-x carlos staff 128 B Tue Aug 13 09:40:04 2024 │ └── store
.r--r--r-- carlos staff 3.9 KB Tue Aug 13 09:40:04 2024 │ ├── 00.pem
.r--r--r-- carlos staff 3.8 KB Tue Aug 13 09:40:04 2024 │ └── 01.pem
dr-xr-xr-x carlos staff 192 B Tue Aug 13 09:40:04 2024 ├── fixture-hello
.r--r--r-- carlos staff 814 B Tue Aug 13 09:40:04 2024 │ ├── add-keychain.sh
.r--r--r-- carlos staff 869 B Tue Aug 13 09:40:04 2024 │ ├── create-extension.sh
.r--r--r-- carlos staff 74 B Tue Aug 13 09:40:04 2024 │ ├── hello.c
.r--r--r-- carlos staff 5.5 KB Tue Aug 13 09:40:04 2024 │ └── Makefile
dr-xr-xr-x carlos staff 96 B Tue Aug 13 09:40:04 2024 ├── fixture-ls
.r--r--r-- carlos staff 617 B Tue Aug 13 09:40:04 2024 │ └── Makefile
dr-xr-xr-x carlos staff 96 B Tue Aug 13 09:40:04 2024 ├── fixture-syft
.r--r--r-- carlos staff 707 B Tue Aug 13 09:40:04 2024 │ └── Makefile
dr-xr-xr-x carlos staff 160 B Tue Aug 13 09:40:04 2024 └── fixture-x509
.r--r--r-- carlos staff 5 B Tue Aug 13 09:40:04 2024 ├── .gitignore
.r--r--r-- carlos staff 193 B Tue Aug 13 09:40:04 2024 ├── create-domain.sh
.r--r--r-- carlos staff 2.5 KB Tue Aug 13 09:40:04 2024 └── Makefile or at least the same in both mac and linux |
Thanks! Let us know if this strangeness is reproduced again! <3 |
To reproduce:
go clean -modcache
export GOPROXY=direct
git clone https://github.com/goreleaser/goreleaser
cd goreleaser
go mod tidy
Did you retroactively change which commit v0.4.3 points to? Please make a new release v0.4.4 on the HEAD commit to resolve this.
The text was updated successfully, but these errors were encountered: