Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose dependency-snapshot-correlator input #422

Open
willvrny opened this issue Jun 28, 2023 · 1 comment · May be fixed by #482
Open

Expose dependency-snapshot-correlator input #422

willvrny opened this issue Jun 28, 2023 · 1 comment · May be fixed by #482
Assignees
@kzantow
Labels
enhancement New feature or request

Comments

@willvrny
Copy link

willvrny commented Jun 28, 2023 •
edited by kzantow
Loading

I've been exploring using the anchore/sbom-action but have a scenario that would require exposing this input.

When using the action with a GitHub matrix to generate SBOMs for multiple images for submitting to the GitHub dependency API, the correlator is getting set to ${workflow}_${job}. I can't see a way to make this different between matrix runs so it is set to the same value for both. GitHub docs seem to suggest the following:

If you're using a build matrix, then you'll also need to add additional key(s) to distinguish between each submission inside a matrix variation.

It appears the code already supports an input of dependency-snapshot-correlator: https://github.com/anchore/sbom-action/blob/main/src/github/SyftGithubAction.ts#L449

Is it possible to expose this as an input to the action?
@wagoodman wagoodman added the enhancement New feature or request label Jul 11, 2024
@kzantow
Copy link
Contributor

kzantow commented Jul 17, 2024

Many apologies for the delay responding here. I believe since there is already a call to core.getInput("dependency-snapshot-correlator"), that input should work but will probably produce a warning. We could add this to the exposed parameters, but if a user is running this action in a matrix build, it is also required to set the artifact-name. Should we just use this for the correlator instead?

@kzantow kzantow linked a pull request Jul 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kzantow kzantow

Labels
enhancement New feature or request
Projects
OSS
Status: In Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: github correlator name when run in matrix build kzantow-anchore/sbom-action
3 participants
@wagoodman @willvrny @kzantow