Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deprecated release flag #1629

Merged
merged 1 commit into from
Feb 27, 2023
Merged

chore: update deprecated release flag #1629

merged 1 commit into from
Feb 27, 2023

Conversation

spiffcs
Copy link
Contributor

@spiffcs spiffcs commented Feb 27, 2023

A recent release of go-releaser deprecated the --rm-dist flag - this pr upgrades the release command to use the new --clean flag

Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
@github-actions
Copy link

Benchmark Test Results

Benchmark results from the latest changes vs base branch
goos: linux
goarch: amd64
pkg: github.com/anchore/syft/test/integration
cpu: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
                                                          │ ./.tmp/benchmark-3e40a46.txt │
                                                          │            sec/op            │
ImagePackageCatalogers/alpmdb-cataloger-2                                   12.20m ± 26%
ImagePackageCatalogers/ruby-gemspec-cataloger-2                             871.3µ ±  2%
ImagePackageCatalogers/python-package-cataloger-2                           3.119m ±  2%
ImagePackageCatalogers/php-composer-installed-cataloger-2                   677.5µ ±  1%
ImagePackageCatalogers/javascript-package-cataloger-2                       360.6µ ±  1%
ImagePackageCatalogers/dpkgdb-cataloger-2                                   491.9µ ±  2%
ImagePackageCatalogers/rpm-db-cataloger-2                                   455.7µ ±  2%
ImagePackageCatalogers/java-cataloger-2                                     10.92m ±  0%
ImagePackageCatalogers/graalvm-native-image-cataloger-2                     7.826µ ±  2%
ImagePackageCatalogers/apkdb-cataloger-2                                    810.6µ ±  1%
ImagePackageCatalogers/go-module-binary-cataloger-2                         18.28µ ±  1%
ImagePackageCatalogers/dotnet-deps-cataloger-2                              976.1µ ±  1%
ImagePackageCatalogers/portage-cataloger-2                                  295.6µ ±  1%
ImagePackageCatalogers/sbom-cataloger-2                                     104.7µ ±  1%
ImagePackageCatalogers/binary-cataloger-2                                   144.4µ ±  1%
geomean                                                                     464.2µ

                                                          │ ./.tmp/benchmark-3e40a46.txt │
                                                          │             B/op             │
ImagePackageCatalogers/alpmdb-cataloger-2                                   5.061Mi ± 0%
ImagePackageCatalogers/ruby-gemspec-cataloger-2                             141.8Ki ± 0%
ImagePackageCatalogers/python-package-cataloger-2                           946.9Ki ± 0%
ImagePackageCatalogers/php-composer-installed-cataloger-2                   155.8Ki ± 0%
ImagePackageCatalogers/javascript-package-cataloger-2                       95.91Ki ± 0%
ImagePackageCatalogers/dpkgdb-cataloger-2                                   144.7Ki ± 0%
ImagePackageCatalogers/rpm-db-cataloger-2                                   170.7Ki ± 0%
ImagePackageCatalogers/java-cataloger-2                                     2.722Mi ± 0%
ImagePackageCatalogers/graalvm-native-image-cataloger-2                     1.523Ki ± 0%
ImagePackageCatalogers/apkdb-cataloger-2                                    207.5Ki ± 0%
ImagePackageCatalogers/go-module-binary-cataloger-2                         3.102Ki ± 0%
ImagePackageCatalogers/dotnet-deps-cataloger-2                              314.2Ki ± 0%
ImagePackageCatalogers/portage-cataloger-2                                  75.53Ki ± 0%
ImagePackageCatalogers/sbom-cataloger-2                                     13.06Ki ± 0%
ImagePackageCatalogers/binary-cataloger-2                                   21.19Ki ± 0%
geomean                                                                     110.7Ki

                                                          │ ./.tmp/benchmark-3e40a46.txt │
                                                          │          allocs/op           │
ImagePackageCatalogers/alpmdb-cataloger-2                                    86.71k ± 0%
ImagePackageCatalogers/ruby-gemspec-cataloger-2                              2.159k ± 0%
ImagePackageCatalogers/python-package-cataloger-2                            15.48k ± 0%
ImagePackageCatalogers/php-composer-installed-cataloger-2                    3.457k ± 0%
ImagePackageCatalogers/javascript-package-cataloger-2                        1.253k ± 0%
ImagePackageCatalogers/dpkgdb-cataloger-2                                    2.646k ± 0%
ImagePackageCatalogers/rpm-db-cataloger-2                                    3.759k ± 0%
ImagePackageCatalogers/java-cataloger-2                                      38.26k ± 0%
ImagePackageCatalogers/graalvm-native-image-cataloger-2                       40.00 ± 0%
ImagePackageCatalogers/apkdb-cataloger-2                                     5.000k ± 0%
ImagePackageCatalogers/go-module-binary-cataloger-2                           101.0 ± 0%
ImagePackageCatalogers/dotnet-deps-cataloger-2                               5.011k ± 0%
ImagePackageCatalogers/portage-cataloger-2                                   1.487k ± 0%
ImagePackageCatalogers/sbom-cataloger-2                                       392.0 ± 0%
ImagePackageCatalogers/binary-cataloger-2                                     649.0 ± 0%
geomean                                                                      2.243k

@spiffcs spiffcs merged commit 98e737f into main Feb 27, 2023
@spiffcs spiffcs deleted the makefile-updates branch February 27, 2023 20:57
@kzantow kzantow added the changelog-ignore Don't include this issue in the release changelog label Mar 2, 2023
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-ignore Don't include this issue in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants