Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD]#159687667 Enable manager to delete users and trainers from a gym #21

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ja-odur
Copy link
Contributor

@ja-odur ja-odur commented Aug 16, 2018

What does this PR do?

  • Enable gym managers to delete users' and trainers' account from the gym, not the application.
  • Enable gym administrators to add already existing users to the gym.

Description of Task to be completed?

  • Modify UI to enable gym managers adding already existing users to the gym.
  • Add GymAddExistingUserForm form and GymAddExistingUserView view.

How should this be manually tested?

  • Clone this branch and follow the instructions stated in README to set up the application.
  • After setting up the application, start the server by running the command python manage.py runserver in the terminal with your virtual environment set.
  • In the browser, log in as an Admin and go to the gyms page. As an admin or a gym manager, you should be able to delete, and create users as shown in the screenshots section.

What are the relevant pivotal tracker stories?

159687667

Screenshots

Screenshot before the implementation
screen shot 2018-08-08 at 19 54 17

Screenshots after implementation
screen shot 2018-08-16 at 12 11 26

screen shot 2018-08-16 at 12 11 45

@coveralls
Copy link

coveralls commented Aug 16, 2018

Pull Request Test Coverage Report for Build 369

  • 75 of 85 (88.24%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 93.191%

Changes Missing Coverage Covered Lines Changed/Added Lines %
wger/gym/forms.py 14 17 82.35%
wger/gym/views/gym.py 36 43 83.72%
Totals Coverage Status
Change from base Build 342: 0.2%
Covered Lines: 12387
Relevant Lines: 13292

💛 - Coveralls

@ja-odur ja-odur force-pushed the ft-more-than-one-gyms-159687667 branch 2 times, most recently from ac3ff3c to 8cf63c4 Compare August 16, 2018 10:37
@ja-odur ja-odur changed the title [WIP] #159687667 Enable manager to delete from a gym and add alre… [WIP] #159687667 Enable manager to delete users and trainers from a gym Aug 16, 2018
@ja-odur ja-odur force-pushed the ft-more-than-one-gyms-159687667 branch 2 times, most recently from a734614 to df976db Compare August 17, 2018 07:08
@ja-odur ja-odur changed the title [WIP] #159687667 Enable manager to delete users and trainers from a gym #159687667 Enable manager to delete users and trainers from a gym Aug 17, 2018
@ja-odur ja-odur force-pushed the ft-more-than-one-gyms-159687667 branch 3 times, most recently from 5060e0a to 9da6c3f Compare August 20, 2018 07:12
…ady existing users to the gym.

  The following changes have been made:
   * Modified the UI to enable addition of already existing users to the gym.
   * Enabled deletion of users from the gym only but not the entire app.
   * Created form to verify if the user already exists.
   * added tests.

 [Delivers #159687667]
@ja-odur ja-odur force-pushed the ft-more-than-one-gyms-159687667 branch from 9da6c3f to fddbba9 Compare August 20, 2018 07:15
@ja-odur ja-odur changed the title #159687667 Enable manager to delete users and trainers from a gym [HOLD]#159687667 Enable manager to delete users and trainers from a gym Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants