[Feature #159236209] Export and Import workouts #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasswa-derick
force-pushed
the
ft-export-workouts-159236209
branch
from
9197080
to
cbd7199
Compare
Pull Request Test Coverage Report for Build 532
💛 - Coveralls |
solnsubuga
reviewed
Aug 30, 2018
| {% block options %} | ||
| <div class="dropdown"> | ||
| <button class="btn btn-success dropdown-toggle" type="button" id="dropdownMenu1" data-toggle="dropdown" aria-haspopup="true" aria-expanded="true"> | ||
| Add workout | ||
| <span class="caret"></span> | ||
| </button> | ||
|
|
There was a problem hiding this comment.
Kindly remove these irrelevant blank lines, you added.
| <ul class="dropdown-menu" aria-labelledby="dropdownMenu1"> | ||
| <li><a href="{% url 'manager:workout:add' %}?cycle=micro">Microcycle: One week plan</a></li> | ||
| <li><a href="{% url 'manager:workout:add' %}?cycle=meso">Mesocycle: Two to six weeks plan</a></li> | ||
| <li><a href="{% url 'manager:workout:add' %}?cycle=macro">Macrocycle: One year plan</a></li> | ||
| </ul> | ||
|
|
There was a problem hiding this comment.
Kindly remove these irrelevant blank lines, you added.
wger/manager/views/workout.py
Outdated
|
|
||
| from django.shortcuts import render, get_object_or_404 | ||
| from django.shortcuts import render, redirect, get_object_or_404 |
There was a problem hiding this comment.
Kindly remove unused import redirect .
wger/manager/views/workout.py
Outdated
| @@ -48,6 +64,8 @@ | |||
| WgerDeleteMixin | |||
| ) | |||
| from wger.utils.helpers import make_token | |||
| from django.http import HttpResponse | |||
There was a problem hiding this comment.
Kindly move these imports to the top of the file.
wger/manager/views/workout.py
Outdated
| messages.info(request, 'No File was Chosen for Importation!') | ||
| return HttpResponseRedirect('overview') | ||
|
|
||
| file = request.FILES['workoutfile'] |
There was a problem hiding this comment.
Move file into the try block and use one try block
wasswa-derick
force-pushed
the
ft-export-workouts-159236209
branch
from
cbd7199
to
7a4592e
Compare
* Create the export url action handler * Implement export and import workouts functionality * Test export and import workouts functions * Resolve flake8 errors * Remove unused modules * Remove unnecessary blank lines * Correct imports and structure of the try statements [Delivers #159236209]
wasswa-derick
force-pushed
the
ft-export-workouts-159236209
branch
from
7a4592e
to
bb64fb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Task to be completed?
How should this be manually tested?
https://github.com/andela/wg-wits.git.cd wg-witsft-export-workouts-159236209branch.virtualenv -p python3 venv-djangothensource venv-django/bin/activatepython manage.py runserverhttp://127.0.0.1:8000/en/workout/overviewto go to the workouts view.What are the relevant pivotal tracker stories?
#159236209
Screenshots (if appropriate)