Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lxc_container option and documentation #39

Merged

Conversation

dmp1ce
Copy link

@dmp1ce dmp1ce commented Jun 10, 2021

No description provided.

@andreasscherbaum
Copy link
Owner

How can this be tested?

@dmp1ce
Copy link
Author

dmp1ce commented Jun 10, 2021

I don't think the automated Github actions test lxc_hosts options currently. That is what we need to do for testing.

I tested locally for lxc_container and it worked for me.

@AnvithLobo
Copy link

AnvithLobo commented Jun 10, 2021

#37 (comment)

https://github.com/AnvithLobo/ansible-lxc-ssh

I've written a test for it now feel free to refactor and adopt it how you see fit for this project.

@andreasscherbaum
Copy link
Owner

@dmp1ce Can you please rebase and push this PR, to fire the new tests again? Thanks.

@dmp1ce dmp1ce force-pushed the lxc_container_option branch from 8a8f6fb to 2bbd92e Compare August 2, 2021 16:23
@dmp1ce
Copy link
Author

dmp1ce commented Aug 2, 2021

@dmp1ce Can you please rebase and push this PR, to fire the new tests again? Thanks.

👍

@stefangweichinger
Copy link

Ah, yes, I just wanted to vote for merging this one as well. Looks good also.

@andreasscherbaum andreasscherbaum merged commit be72f62 into andreasscherbaum:master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants