Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crystal structure column #15

Open
madsfaerch opened this issue Apr 27, 2017 · 2 comments
Open

Add crystal structure column #15

madsfaerch opened this issue Apr 27, 2017 · 2 comments

Comments

@madsfaerch
Copy link
Contributor

madsfaerch commented Apr 27, 2017

Hi again,

I think it would be nice to include a crystal structure column in the dataset.
Crystal structures are available for all elements, except for 113-117, which is great.

I propose using data from Wikipedia's article Periodic table (crystal_structure)

@andrejewski
Copy link
Owner

I appreciate your enthusiasm. I have no problem adding more accurate information to the dataset. If you have a few minutes tomorrow to talk, I'd have no problem making you a contributor to the project. Let me know, my email is christopher.andrejewski@gmail.com. Or if you'd like to PR and move on with your life too that's fine.

@sabidhasan
Copy link

@andrejewski

Hello, just came across this repo and as a chemist-dabbling-in-coding, I'd love to help with some issues.

Please let me know if I can do this crystal structure column - if so, I can fork and make a PR, or if you want to discuss, I am open to that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants