fix bug that was causing user_domain_id to not be unique for each user

fake_web_events/event.py

@@ -13,7 +13,7 @@ class Event(WeightedRandom):
     def __init__(self, current_timestamp: datetime, user: User, batch_size: int):
         self.previous_page = None
         self.current_page = self.select('landing_pages')
-        self.user = user.asdict()
+        self.user = user
         self.batch_size = batch_size
         self.current_timestamp = self.randomize_timestamp(current_timestamp)
         self.is_new_page = True

fake_web_events/user.py

@@ -155,10 +155,10 @@ def __init__(self, size: int):
 
     def populate_pool(self):
         logging.info('Creating UserPool. This might take a while depending on your pool size.')
-        for idx in range(self.size):
+        for idx in range(1, self.size + 1):
             if idx % 100 == 0:
                 logging.info(f'{idx} users created.')
-            self.pool.append(User())
+            self.pool.append(User().asdict())
 
     def __repr__(self) -> str:
         return repr(self.pool)

setup.py

@@ -7,7 +7,7 @@
 
 setup(
     name='fake_web_events',
-    version='0.2.2',
+    version='0.2.3',
     description='Generator of semi-random fake web events. ',
     long_description=long_description,
     long_description_content_type='text/markdown',

tests/test_simulation.py

@@ -52,3 +52,9 @@ def test_get_rate_per_step(self, mock_simulation):
 
     def test_update(self, mock_simulation, mock_update):
         assert mock_simulation.get_len_sessions() == 4
+
+    def test_max_unique_user_ids(self, mock_simulation):
+        # after running the simulation for some time, the max unique user ids must be equal to the pool size
+        events = list(mock_simulation.run(2))
+        user_domain_ids = set(event['user_domain_id'] for event in events)
+        assert len(user_domain_ids) == 10

tests/test_user.py

@@ -83,7 +83,7 @@ def test_pool_size(self, mock_user_pool):
         assert len(mock_user_pool.pool) == 10
 
     def test_get_user(self, mock_user_pool):
-        assert isinstance(mock_user_pool.get_user(), User)
+        assert isinstance(mock_user_pool.get_user(), dict)
 
     def test_pool_size_after_getting_user(self, mock_user_pool):
         mock_user_pool.get_user()