Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commands that are janet functions don't necessarily need argument string conversion #190

Open
andrewchambers opened this issue Jun 4, 2019 · 0 comments
Labels
enhancement New feature or request maybe

Comments

@andrewchambers
Copy link
Owner

andrewchambers commented Jun 4, 2019

It may be desirable to explicitly allow and write tests for things like:

($ (fn [table] (pp table)) @{"foo" "bar"})
@{"foo" "bar"}

Because a function is not an external command, but it still run after fork(), it could take arguments as other data types.

The counter argument is that it is consistent and simpler to just treat all commands as functions taking a list of strings. We need to flatten args anyway to deal with globbing.

@andrewchambers andrewchambers added enhancement New feature or request maybe labels Jun 4, 2019
@andrewchambers andrewchambers changed the title Commands that are janet functions don't necessarily need string conversion Commands that are janet functions don't necessarily need argument string conversion Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maybe
Projects
None yet
Development

No branches or pull requests

1 participant