Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pigg 186 rppal #355

Merged
merged 51 commits into from
Aug 14, 2024
Merged

Pigg 186 rppal #355

merged 51 commits into from
Aug 14, 2024

Conversation

andrewdavidmackenzie
Copy link
Owner

Fixes #186

Prior to merge:

  • check how it performs on real pi hw
  • wait until a release is done, don't use git version

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 44.07895% with 85 lines in your changes missing coverage. Please review.

Project coverage is 28%. Comparing base (a99815d) to head (22d76bd).
Report is 45 commits behind head on master.

Files Patch % Lines
src/modal_handler.rs 52% 58 Missing ⚠️
src/piggui.rs 0% 14 Missing ⚠️
src/views/hardware_view.rs 0% 10 Missing ⚠️
src/views/hardware_menu.rs 0% 2 Missing ⚠️
src/views/version.rs 0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #355    +/-   ##
======================================
- Coverage      32%    28%    -4%     
======================================
  Files          37     37            
  Lines        4355   4278    -77     
======================================
- Hits         1393   1187   -206     
- Misses       2962   3091   +129     
Flag Coverage Δ
unittests 28% <45%> (-4%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sundaram123krishnan and others added 23 commits August 8, 2024 17:45
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.204 to 1.0.205.
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](serde-rs/serde@v1.0.204...v1.0.205)

---
updated-dependencies:
- dependency-name: serde
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Add two arm targets to list for release.yml
Bumps [clap](https://github.com/clap-rs/clap) from 4.5.13 to 4.5.14.
- [Release notes](https://github.com/clap-rs/clap/releases)
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md)
- [Commits](clap-rs/clap@clap_complete-v4.5.13...v4.5.14)

---
updated-dependencies:
- dependency-name: clap
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…ap-4.5.14

Bump clap from 4.5.13 to 4.5.14
@andrewdavidmackenzie andrewdavidmackenzie self-assigned this Aug 9, 2024
sundaram123krishnan and others added 22 commits August 9, 2024 23:35
Disable more code when building for wasm32 (for web)
Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.122 to 1.0.124.
- [Release notes](https://github.com/serde-rs/json/releases)
- [Commits](serde-rs/json@v1.0.122...v1.0.124)

---
updated-dependencies:
- dependency-name: serde_json
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.205 to 1.0.206.
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](serde-rs/serde@v1.0.205...v1.0.206)

---
updated-dependencies:
- dependency-name: serde
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…rde_json-1.0.124

Bump serde_json from 1.0.122 to 1.0.124
…rde-1.0.206

Bump serde from 1.0.205 to 1.0.206
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.206 to 1.0.207.
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](serde-rs/serde@v1.0.206...v1.0.207)

---
updated-dependencies:
- dependency-name: serde
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…rde-1.0.207

Bump serde from 1.0.206 to 1.0.207
@andrewdavidmackenzie
Copy link
Owner Author

Works perfectly on real hardware - better than before.

@andrewdavidmackenzie andrewdavidmackenzie marked this pull request as ready for review August 14, 2024 14:00
@andrewdavidmackenzie andrewdavidmackenzie merged commit 3cfcc9a into master Aug 14, 2024
13 checks passed
@andrewdavidmackenzie andrewdavidmackenzie deleted the pigg-186-rppal branch August 14, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LevelChanges reported when in fact level stays the same
2 participants