Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename score_agg_fn attribute to something more descriptive #3

Closed
andrewrosss opened this issue May 10, 2020 · 1 comment
Closed

Rename score_agg_fn attribute to something more descriptive #3

andrewrosss opened this issue May 10, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@andrewrosss
Copy link
Owner

Some potential options could be:

  • phase_score_fn
  • token_agg_fn
  • token_score_agg_fn

Basically, something that indicates that this function takes the scores for each word in a phrase and produces an aggregate of those scores, from which those scores are used to rank the phrases.
@andrewrosss andrewrosss added the enhancement New feature or request label May 10, 2020
@andrewrosss
Copy link
Owner Author

The word_scorer_class attribute on the Rake object (introduced in #8) addresses this. Perhaps the name could still be better, but closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrewrosss