Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for icon (.ico) files #76

Closed
kleisauke opened this issue Feb 12, 2017 · 4 comments
Closed

Add support for icon (.ico) files #76

kleisauke opened this issue Feb 12, 2017 · 4 comments
Assignees
@kleisauke
Labels
completed Feature or request has been completed enhancement New feature or request
Milestone
v3.0.0

Comments

@kleisauke
Copy link
Member

Add support for icon (.ico) files [7550209]

Submitted by Jacob H on 13-4-2015 0:00:00
2 votes on UserVoice prior to migration

This would be useful for shortcut icons, such as http://www.google.co.uk/favicon.ico

Response

by Andries Louw Wolthuizen on 17-5-2015 0:00:00

I’ve implemented .ico support, but this is only for .ico files as source.
Example: http://images.weserv.nl/?url=www.google.nl/favicon.ico&h=12&w=12
(The url on .co.uk is currently wrongly cached by the proxy)
I will need to look into exporting as a .ico file.

Comments

Comment by Jacob H on 17-5-2015 16:04:00

Thank you! This will be very useful.

Original UserVoice Submission
@kleisauke kleisauke added the started This issue is being worked on label Feb 12, 2017
@kleisauke kleisauke added this to the v3.0.0 milestone Feb 12, 2017
@andrieslouw
Copy link
Member

Needs libvips/php-vips#34 for milestone v3.0.0

@andrieslouw andrieslouw assigned kleisauke and unassigned kleisauke Mar 28, 2017
@andrieslouw
Copy link
Member

libvips/php-vips#34 has been fixed, need to wait for libvips 8.5 to appear in repo's.

@andrieslouw andrieslouw added the enhancement New feature or request label Mar 28, 2017
@andrieslouw
Copy link
Member

Needs libvips/php-vips-ext#7 to implement in production.

@andrieslouw andrieslouw added completed Feature or request has been completed and removed started This issue is being worked on labels Apr 10, 2017
@andrieslouw
Copy link
Member

libvips/php-vips-ext#7 is fixed, PECL has been updated, libvips updated to 8.5.2 in production thanks to https://git.remirepo.net/cgit/rpms/lib/vips.git/commit/?id=69047e379be1e5abfc0998178c997e1ca6aae13f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kleisauke kleisauke

Labels
completed Feature or request has been completed enhancement New feature or request
Milestone
v3.0.0
Development

No branches or pull requests
2 participants
@andrieslouw @kleisauke