From 028ba890c58b47293ad4b7d3ebfac11f1a1a7f28 Mon Sep 17 00:00:00 2001 From: Mike Hardy Date: Tue, 18 May 2021 13:56:38 -0500 Subject: [PATCH] fix(android): correct lint issues for various API mis-use Highlights: - enforce CallSuper so TaskExecutors will always clean up correctly - enforce Locale translation in string manipulaton (Fixes #3917) --- .../invertase/firebase/auth/ReactNativeFirebaseAuthModule.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/android/src/main/java/io/invertase/firebase/auth/ReactNativeFirebaseAuthModule.java b/android/src/main/java/io/invertase/firebase/auth/ReactNativeFirebaseAuthModule.java index 4e5b4f4e72..d30755e22a 100644 --- a/android/src/main/java/io/invertase/firebase/auth/ReactNativeFirebaseAuthModule.java +++ b/android/src/main/java/io/invertase/firebase/auth/ReactNativeFirebaseAuthModule.java @@ -61,6 +61,7 @@ import java.util.HashMap; import java.util.Iterator; import java.util.List; +import java.util.Locale; import java.util.Map; import java.util.Objects; import java.util.concurrent.TimeUnit; @@ -1885,7 +1886,7 @@ private WritableMap getJSError(Exception exception) { } code = code - .toLowerCase() + .toLowerCase(Locale.ROOT) .replace("error_", "") .replace('_', '-'); error.putString("code", code);