Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump clap to >4.x #126

Merged
merged 7 commits into from
Oct 9, 2022
Merged

build(deps): bump clap to >4.x #126

merged 7 commits into from
Oct 9, 2022

Conversation

andros21
Copy link
Owner

@andros21 andros21 commented Oct 2, 2022

major version bump, include some additional commit before apply #121 and #120
that must be bumped to 4.x together to avoid inconsistencies

andros21 and others added 4 commits October 2, 2022 09:58
with the command `cargo check --features clap/deprecated`
see https://github.com/clap-rs/clap/blob/master/CHANGELOG.md#migrating
for todo list pre major release bump >4.x
Bumps [clap](https://github.com/clap-rs/clap) from 3.2.19 to 4.0.7.
- [Release notes](https://github.com/clap-rs/clap/releases)
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md)
- [Commits](clap-rs/clap@v3.2.19...v4.0.7)

---
updated-dependencies:
- dependency-name: clap
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
no more needed for clap>4.x
Bumps [clap_complete](https://github.com/clap-rs/clap) from 3.2.3 to 4.0.2.
- [Release notes](https://github.com/clap-rs/clap/releases)
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md)
- [Commits](clap-rs/clap@clap_complete-v3.2.3...clap_complete-v4.0.2)

---
updated-dependencies:
- dependency-name: clap_complete
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@andros21 andros21 added enhancement New feature or request dependencies Pull requests that update a dependency file labels Oct 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2022

Coverage Report

Coverage after merging clap-4.x into master will be
83.25%
Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
src
   cli.rs0%100%0%0%100–438, 444, 55–99
   main.rs0.52%100%3.03%0.28%100–107, 112–205, 207–211, 214–218, 221, 223–250, 255–312, 315, 317–344, 349–355, 357, 359–360, 362, 364–366, 368–392, 394–402, 404–414, 416, 419, 422–423, 61–68, 71, 78–99

are automatically added, otherwise main panic
must be specified that have no argument,
and the bool that will be registred when present,
in our case all of type "set true if present"

also in main there is API change `get_flag`
instead of `contains_id`
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2022

Coverage Report

Coverage after merging clap-4.x into master will be
83.14%
Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
src
   cli.rs0%100%0%0%100–445, 451, 55–99
   main.rs0.52%100%3.03%0.28%100–107, 112–205, 207–211, 214–218, 221, 223–250, 255–312, 315, 317–344, 349–355, 357, 359–360, 362, 364–366, 368–392, 394–402, 404–414, 416, 419, 422–423, 61–68, 71, 78–99

@andros21 andros21 merged commit deeab6c into master Oct 9, 2022
@andros21 andros21 deleted the clap-4.x branch October 9, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant