Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(main): fail-fast for invalid/unsupported file format #37

Merged
merged 1 commit into from
May 17, 2022
Merged

feat(main): fail-fast for invalid/unsupported file format #37

merged 1 commit into from
May 17, 2022

Conversation

andros21
Copy link
Owner

not stderr and exit1 after the computation but before

@andros21
feat(main): fail-fast for invalid/unsupported file format
0b2b31f 
not stderr and exit1 after the computation but before
@andros21 andros21 added the enhancement New feature or request label May 11, 2022
@andros21 andros21 self-assigned this May 11, 2022
@andros21
Copy link
Owner Author

andros21 commented May 11, 2022 •
edited
Loading

this should save a lot of time when user try to use incorrect output file e.g. my_render.avi

@github-actions
Copy link
Contributor

Coverage Report

Coverage after merging fail-fast into master will be
86.38%
Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
src
   main.rs1.79%100%9.09%0.99%100–102, 105–144, 43–48, 55–76, 78–99
   misc.rs65.22%100%50%73.33%31

@Paolo-Azzini Paolo-Azzini merged commit 6e0fa37 into master May 17, 2022
@andros21 andros21 deleted the fail-fast branch May 17, 2022 12:24
andros21 added a commit that referenced this pull request Jun 24, 2022
@andros21
feat(main): fail-fast for invalid/unsupported file format (#37)
dfd567e 
not stderr and exit1 after the computation but before

[skip ci]
Paolo-Azzini pushed a commit that referenced this pull request Jun 25, 2022
@andros21 @Paolo-Azzini
feat(main): fail-fast for invalid/unsupported file format (#37)
03eb2e0 
not stderr and exit1 after the computation but before

[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paolo-Azzini Paolo-Azzini Paolo-Azzini approved these changes

Assignees

@andros21 andros21

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andros21 @Paolo-Azzini