Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f'temp and speed should have the same length' #6

Closed
Delitants opened this issue Jul 20, 2020 · 4 comments
Closed

f'temp and speed should have the same length' #6

Delitants opened this issue Jul 20, 2020 · 4 comments

Comments

@Delitants
Copy link

Delitants commented Jul 20, 2020

sudo $(which coolgpus) --speed 99 99
File "/usr/bin/coolgpus", line 28
assert len(args.temp) == len(args.speed), f'temp and speed should have the same length'
^
SyntaxError: invalid syntax

Huh??

@Delitants
Copy link
Author

Edit coolgpus file and set python 3.6 or higher

@v-iashin
Copy link
Contributor

I think that was my PR so I will respond. Indeed, there is no reason for string formatting in this case but it breaks python version compatibility. Maybe I wanted to format them somehow, then, decided not to, and forgot to remove f prefixes.

@andyljones can we fix it in the next update just by removing f prefix?

@Delitants
Copy link
Author

This issue was cosmetical, the major issue followed in ticket #7
Not sure if also related to python version, but feels like loop is just not looping at all. No errors.

@andyljones
Copy link
Owner

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants