Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve displaying of waveforms #2

Open
anfractuosity opened this issue Feb 5, 2023 · 9 comments
Open

Improve displaying of waveforms #2

anfractuosity opened this issue Feb 5, 2023 · 9 comments

Comments

@anfractuosity
Copy link
Owner

We have to currently wait for the whole buffer to be filled, which is 128 samples. For long
time periods, e.g 1s time period, that would be 128 seconds before display is updated.

@thermionik
Copy link

thermionik commented Jan 1, 2025

Hi! I have a question about the version installed from flipper lab. The waveform is squashed to the bottom of the display and I can only see the peaks. How do I center the waveform on the display so that I can see troughs too? Any help would be greatly appreciated. Also, I'd like to thank you for your hard work on this program over the years! Unfortunately my old version of the app quit working when I accidentally updated my flipper's firmware.

@anfractuosity
Copy link
Owner Author

anfractuosity commented Jan 1, 2025

Hi, good question, there's currently no functionality to 'scale' the signal. I can possibly add simple software scaling, however the ADC does only capture voltages ranging from 0V to 2.5V.

If you have time sometime, if you use the 'capture' functionality to create a 128 sample binary dump and attach it here, I could have a look if scaling the signal might help.

When you say - "Unfortunately my old version of the app quit working when I accidentally updated my flipper's firmware." am I right in thinking the current version in the app store does work for you though?

@thermionik
Copy link

thermionik commented Jan 1, 2025

Pulse.zip
Screenshot-20250101-165534

Good afternoon. I attached the dump of a signal and additionally a screenshot of my display.

To clarify, yes the new version of the app from Flipper Lab runs fine on my flipper, the problem is the waveform does not look quite as pretty as it used to in version 0.01 of the program. Thanks for your help!

@thermionik
Copy link

Well silly me, I realized now that the problem was my signal and not my scope. Everything is working perfectly fine it appears. The problem was that the signal itself had a DC offset of 0, flipperscope naturally has 0 Volts at the bottom of the viewport. A DC offset of 1 applied to the signal yields the following, beautiful waveform:
Screenshot-20250101-165534

@thermionik
Copy link

Some sort of scaling would still be a very powerful and useful feature, in the coming days I may attempt to mess around with the code. If you feel like adding that yourself I would welcome the adjustment! :)

@anfractuosity
Copy link
Owner Author

Thanks for the screenshots, very helpful :) I think a scaling feature is a good idea, will see if I can add one.

@anfractuosity
Copy link
Owner Author

@thermionik I've just created some new changes, with scaling support, attached the binary here -
flipperscope.zip

It for example can scale the waveform 2x.

If you notice any issues with it please let me know. Thanks!

@thermionik
Copy link

thermionik commented Jan 3, 2025

Hey, just got a chance to test the scaling. Nice job on it. It suits my needs perfectly.

@anfractuosity
Copy link
Owner Author

Thanks for testing :) Hopefully will be in the flipper app store soon too. I'll then hopefully have time soon to start looking at issue #5 again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants