From 39fafd2b09ecff1cb6404b0bcc5438bad4195902 Mon Sep 17 00:00:00 2001 From: NycroV <83246959+NycroV@users.noreply.github.com> Date: Sun, 22 Sep 2024 23:17:29 -0400 Subject: [PATCH 1/2] Remove null propogation from queued extensions --- .../Extensions/QueuedLavalinkPlayerExtensions.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Lavalink4NET/Extensions/QueuedLavalinkPlayerExtensions.cs b/src/Lavalink4NET/Extensions/QueuedLavalinkPlayerExtensions.cs index e8a99baf..a175acc5 100644 --- a/src/Lavalink4NET/Extensions/QueuedLavalinkPlayerExtensions.cs +++ b/src/Lavalink4NET/Extensions/QueuedLavalinkPlayerExtensions.cs @@ -12,12 +12,12 @@ public static async ValueTask PlayAsync(this IQueuedLavalinkPlayer player, { cancellationToken.ThrowIfCancellationRequested(); - var queueOffset = default(int?); + int? queueOffset = default; if (loadResult.Playlist is null) { // Single track - queueOffset ??= await player + queueOffset = await player .PlayAsync(loadResult.Track!, cancellationToken: cancellationToken) .ConfigureAwait(false); } @@ -26,7 +26,7 @@ public static async ValueTask PlayAsync(this IQueuedLavalinkPlayer player, // Playlist foreach (var track in loadResult.Tracks) { - queueOffset ??= await player + queueOffset = await player .PlayAsync(track, cancellationToken: cancellationToken) .ConfigureAwait(false); } From ab05f902af32f9547e423316e1fcb52a05346a1e Mon Sep 17 00:00:00 2001 From: NycroV <83246959+NycroV@users.noreply.github.com> Date: Sun, 22 Sep 2024 23:43:05 -0400 Subject: [PATCH 2/2] Documentation --- .../Extensions/QueuedLavalinkPlayerExtensions.cs | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/Lavalink4NET/Extensions/QueuedLavalinkPlayerExtensions.cs b/src/Lavalink4NET/Extensions/QueuedLavalinkPlayerExtensions.cs index a175acc5..81b0ef41 100644 --- a/src/Lavalink4NET/Extensions/QueuedLavalinkPlayerExtensions.cs +++ b/src/Lavalink4NET/Extensions/QueuedLavalinkPlayerExtensions.cs @@ -8,6 +8,15 @@ public static class QueuedLavalinkPlayerExtensions { + /// + /// Adds a to the player's queue.
+ /// Returns the index of the track in the queue (or the last track added to the queue if is a playlist) + ///
+ /// The player to enqueue the load result to. + /// The load result you want to enqueue. + /// The cancellation token. + /// The index of the track in the queue (or the last track added to the queue if is a playlist) + /// When the contains no tracks. public static async ValueTask PlayAsync(this IQueuedLavalinkPlayer player, TrackLoadResult loadResult, CancellationToken cancellationToken = default) { cancellationToken.ThrowIfCancellationRequested();