Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In pixel clustering, if restarting create_pixel_matrix, not all FOVs are used to find the 99.9th percentile values #1016

Closed
cliu72 opened this issue Jun 14, 2023 · 0 comments · Fixed by #1020
Assignees
Labels
bug Something isn't working

Comments

@cliu72
Copy link
Contributor

cliu72 commented Jun 14, 2023

Describe the bug
If the create_pixel_matrix function in the pixel clustering notebook crashes or is stopped before it finishes for whatever reason, there is code in place to ignore any FOVs that have already been processed (https://github.com/angelolab/ark-analysis/blob/0266b96c689e9118f3b77355fe08df8f9c17b52c/src/ark/phenotyping/pixie_preprocessing.py#LL245-L258). However, this causes a problem with generating the 99.9th percentile values because only the FOVs that were processed will be used to generate the 99.9th percentile values (ignoring all FOVs that have already been processed). The correct behavior is to use all FOVs to calculate the 99.9th percentile values.

Expected behavior
Either re-calculate the 99.9th percentile values for FOVs that have already been processed at the start of the function, or save the 99.9th percentile values for each FOV as we go. Open to other suggestions as well.

@cliu72 cliu72 added the bug Something isn't working label Jun 14, 2023
@camisowers camisowers self-assigned this Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants