Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have just one mantis directory #669

Closed
cliu72 opened this issue Aug 24, 2022 · 3 comments · Fixed by #1061
Closed

Have just one mantis directory #669

cliu72 opened this issue Aug 24, 2022 · 3 comments · Fixed by #1061
Assignees
Labels
enhancement New feature or request

Comments

@cliu72
Copy link
Contributor

cliu72 commented Aug 24, 2022

Is your feature request related to a problem? Please describe.
Right now, mantis directories are created at the end of the notebooks for pixel clustering, cell clustering, and neighborhood analysis. When generating a mantis directory, all the single-channel TIFs are copied, so right now, the data is being copied in all 3 of these places, which is inefficient.

Describe the solution you'd like
Have just one mantis directory (probably in the base directory), that will hold single-channel TIFs, pixel overlay, cell overlay, and neighborhood overlay. In Mantis, the user can choose which of these overlays they want to look at.

Also have an option for the user to add a prefix (or suffix) to the pixel/cell/neighborhood mask overlays, so that they can compare across different runs. I think it is a good idea to have as default, no prefix/suffix and the mask overlays are overwritten if one already exists in the directory. If the user chooses, they can add a prefix/suffix to the files (such as "run1_population_pixel_mask.tif", "run2_population_pixel_mask.tif", etc.), so these are written as separate files. The user can then choose which of these to view in Mantis for easy comparison.

@cliu72 cliu72 added the enhancement New feature or request label Aug 24, 2022
@srivarra srivarra self-assigned this Aug 24, 2022
@alex-l-kong
Copy link
Contributor

Addressed by #668.

@ngreenwald
Copy link
Member

Nope, it was mentioned there but this is separate

@ngreenwald ngreenwald reopened this Sep 28, 2022
@ngreenwald ngreenwald assigned alex-l-kong and unassigned srivarra Oct 4, 2022
@ngreenwald
Copy link
Member

This will require a design doc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants