Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inertia and silhouette score progress bars for neighborhood analysis notebook #758

Merged
merged 3 commits into from
Oct 11, 2022
Merged

Add inertia and silhouette score progress bars for neighborhood analysis notebook #758

merged 3 commits into from
Oct 11, 2022

Conversation

alex-l-kong
Copy link
Contributor

What is the purpose of this PR?

Closes #566. The inertia and silhouette score computations take a while to complete, so they should have progress bars.

These should be the last progress bars that need to be added to ark.

How did you implement your changes

Use tqdm.notebook as implemented in other modules.

@alex-l-kong alex-l-kong self-assigned this Oct 7, 2022
ngreenwald
ngreenwald requested changes Oct 10, 2022
View reviewed changes
Copy link
Member

@ngreenwald ngreenwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run both notebook cells to make sure formatting on TQDM displays as expected?

@alex-l-kong
Copy link
Contributor Author

Did you run both notebook cells to make sure formatting on TQDM displays as expected?

They are displaying correctly.

@ngreenwald ngreenwald merged commit ddfcbbd into main Oct 11, 2022
@ngreenwald ngreenwald deleted the neighborhood_progress branch October 11, 2022 01:52
@srivarra srivarra added the enhancement New feature or request label Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngreenwald ngreenwald Awaiting requested review from ngreenwald

Assignees

@alex-l-kong alex-l-kong

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Progress updates for compute intensive functions
3 participants
@alex-l-kong @ngreenwald @srivarra