Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example Dataset - Spatial Datasets #832

Merged
merged 9 commits into from
Nov 22, 2022
Merged

Example Dataset - Spatial Datasets #832

merged 9 commits into from
Nov 22, 2022

Conversation

srivarra
Copy link
Contributor

@srivarra srivarra commented Nov 16, 2022 •
edited
Loading

If you haven't already, please read through our contributing guidelines before opening your PR

What is the purpose of this PR?

Closes #814.

How did you implement your changes

Added datasets for:

  • Example Fiber Segmentation
  • Example Neighborhood Analysis
  • Example Pairwise Spatial Enrichment
  • LDA Preprocessing
  • LDA Training and Inference

Remaining issues

  • Merge the hugging face branch to main.

@srivarra srivarra added the enhancement New feature or request label Nov 16, 2022
@srivarra srivarra self-assigned this Nov 16, 2022
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@srivarra srivarra marked this pull request as ready for review November 17, 2022 00:43
@srivarra srivarra marked this pull request as draft November 17, 2022 01:35
@srivarra srivarra marked this pull request as ready for review November 18, 2022 17:46
ngreenwald
ngreenwald requested changes Nov 21, 2022
View reviewed changes
Copy link
Member

@ngreenwald ngreenwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to delete all of the files in /example_data now

ark/utils/example_dataset_test.py Show resolved Hide resolved
@ngreenwald ngreenwald merged commit 44c8e6b into main Nov 22, 2022
@ngreenwald ngreenwald deleted the example_dataset/spatial_analysis branch November 22, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngreenwald ngreenwald Awaiting requested review from ngreenwald

Assignees

@srivarra srivarra

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update spatial analysis notebooks to use Huggingface dataset
2 participants
@srivarra @ngreenwald