Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit hooks for Jupyter notebooks #349

Open
alex-l-kong opened this issue Apr 10, 2023 · 0 comments
Open

Add pre-commit hooks for Jupyter notebooks #349

alex-l-kong opened this issue Apr 10, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@alex-l-kong
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The current pre-commit hooks work very well on the source files, however they don't currently format Jupyter notebooks. We should add a pre-commit hook to handle this.

Describe the solution you'd like

nbQA is the standard. It offers mypy, flake8, and black on top of a lot of other options customized for Jupyter notebook.

Additional context

For our pure Python repos, nbQA would be a good option to add as well.

@alex-l-kong alex-l-kong added the enhancement New feature or request label Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant