Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ngModule #32

Closed
probert94 opened this issue Jan 19, 2017 · 10 comments
Closed

Support for ngModule #32

probert94 opened this issue Jan 19, 2017 · 10 comments
Milestone

Comments

@probert94
Copy link
Contributor

probert94 commented Jan 19, 2017

Angular-CLI has a command for module-generation ("ng g module moduleName").
Using this command, it is possible to create a "normal" module, as well as a "routing" module ("--routing").
It would be cool, if the plugin supports generation for modules and routes, using a Wizard.

@angelozerr
Copy link
Owner

@Springrbua I'm sorry, I'm very busy with other topics like tslint, angular2 language service (to have angular2, tslint validation for @Component/template etc).

Thanks a lot with your contribution.

Could you add a screenshot with a little explnation at https://github.com/angelozerr/angular2-eclipse/wiki/New-and-Noteworthy-1.2.0 like https://github.com/angelozerr/typescript.java/wiki/New-and-Noteworthy-1.2.0

Thanks!

Can we close this issue?

@probert94
Copy link
Contributor Author

probert94 commented Jan 26, 2017

I will make a screenshot as soon as possible.
The second point of the Issue is still open (choose module when generating a Component/Module/Directive etc.)
However I am not (yet) able to do that, as I don't know how to search for existing Moudles...
But we could create a new Issue for that...

@angelozerr
Copy link
Owner

The second point of the Issue is still open (choose module when generating a Component/Module7Directive etc.)

The hardest feature:)

However I am not (yet) able to do that, as I don't know how to search for existing Moudles...

I think we should use tsserver for that. TypeScript 2.2 will provide "plugin" feature to extends TypeScript completion, validation, etc. And Angular guys are implementing a plugin for Angular2 that I'm integrating (I can have completion, validation, hover, etc inside @Component/template (see #30)) a very great feature (and more I'm working too to have HTML syntax coloration inside @Component/template (see #2)).

So once Angular2 language service plugin will be integrated, we could study how to develop a TS 2.2 plugin to existing modules or even create a new issues like https://github.com/angular/angular/search?q=%5B%40angular%2Flanguage-service%5D+&type=Issues&utf8=%E2%9C%93

But we could create a new Issue for that...

Yes please and after please close this issue.

@probert94
Copy link
Contributor Author

@angelozerr How can I edit the wiki page? Do I need some special rights for that?

@angelozerr
Copy link
Owner

@Springrbua do you want to become a contributor?

@probert94
Copy link
Contributor Author

probert94 commented Jan 26, 2017

Well, I would like to update the wikipage, as you said in the first comment, and right now I can't...

However, I preffer to work on my fork, as I am pretty new to Eclipse Plugin-Development (started this week) and I would like to keep your repo cleen and stable :)

@angelozerr
Copy link
Owner

Well, I would like to update the wikipage, as you said in the first comment, and right now I can't...

You should now edit the wiki. For the image, try to clone the wiki and add the images. Otherwise, don't loose your time with that, I will do the screenshot.

However, I preffer to work on my fork, as I am pretty new to Eclipse Plugin-Development (started this week) and I would like to keep your repo cleen and stable :)

I understand. Very impressive if you are neebie with eclipse plugin dev!

@probert94
Copy link
Contributor Author

Well I actually only searched for "Component" or "Directive". Then I only needed to copy the existing code and replace "Component" with "Module" :)

I'll update the Wiki-Page as soon as possible. However, I am a bit busy today, so I might update it tomorrow...

@probert94
Copy link
Contributor Author

@angelozerr I edited the wikipage.
Screenshots are still missing, could you please add them, if it is not too much work?
Thanks

@angelozerr
Copy link
Owner

Thanks @Springrbua I will do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants