fix(undo-redo): prevent duplicated entries on undo stack

angular-architects · Jun 20, 2024 · b4f68af · b4f68af
2 parents 9ac30eb + e360ee6
commit b4f68af
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/libs/ngrx-toolkit/src/lib/with-undo-redo.ts b/libs/ngrx-toolkit/src/lib/with-undo-redo.ts
@@ -161,6 +161,16 @@ SignalStoreFeature<any, any> {
                         return;
                     }
 
+                    // 
+                    // Deep Comparison to prevent duplicated entries
+                    // on the stack. This can e.g. happen after an undo 
+                    // if the component sends back the undone filter 
+                    // to the store.
+                    //
+                    if(JSON.stringify(cand) === JSON.stringify(previous)) {
+                        return;
+                    }
+
                     // Clear redoStack after recorded action
                     redoStack.splice(0);