Skip to content

Commit

Permalink
chore: switch to pnpm (for local dev)
Browse files Browse the repository at this point in the history
Closes #73
  • Loading branch information
jits authored and rainerhahnekamp committed Jul 26, 2024
1 parent bd8cb25 commit c24cba8
Show file tree
Hide file tree
Showing 11 changed files with 17,550 additions and 12,948 deletions.
15 changes: 9 additions & 6 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,17 @@ on:
- main
jobs:
build:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
with:
version: 9
- uses: actions/setup-node@v4
with:
node-version: '18'
cache: 'npm'
- run: npx yarn
- run: npm run build:all
cache: "pnpm"
- run: pnpm install --frozen-lockfile
- run: pnpm run build:all
- run: ./integration-tests.sh

2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,6 @@ testem.log
.DS_Store
Thumbs.db

.nx/cache
.nx
.angular
/versions.txt
1 change: 1 addition & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@
/coverage
/.nx/cache
.angular
pnpm-lock.yaml
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ export class FlightSearchDynamicComponent {

`withStorageSync` adds automatic or manual synchronization with Web Storage (`localstorage`/`sessionstorage`).

> [!WARNING]
> [!WARNING]
> As Web Storage only works in browser environments it will fallback to a stub implementation on server environments.
Example:
Expand Down Expand Up @@ -441,6 +441,8 @@ Since we don't want to bloat the library, we are very selective about new featur
- A use case showing the feature in action in the demo app of the repository.
- An entry to the README.md.

This project uses [pnpm](https://pnpm.io/) to manage dependencies and run tasks (for local development and CI).

### I require a feature that is not available in a lower version. What should I do?

Please create an issue. Very likely, we are able to cherry-pick the feature into the lower version.
Expand Down
2 changes: 1 addition & 1 deletion apps/demo-e2e/playwright.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export default defineConfig({ ...nxE2EPreset(__filename, { testDir: './src' }),
},
/* Run your local dev server before starting the tests */
webServer: {
command: 'npx nx serve demo',
command: 'pnpm nx serve demo',
url: 'http://localhost:4200',
reuseExistingServer: !process.env.CI,
cwd: workspaceRoot,
Expand Down
4 changes: 2 additions & 2 deletions integration-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ do
done < versions.txt

for version in ${versions[*]}; do
npm i @ngrx/signals@$version
pnpm i @ngrx/signals@$version
echo "Building with version $version"
npx nx build --project demo
pnpm nx build --project demo
done
6 changes: 4 additions & 2 deletions libs/ngrx-toolkit/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ export class FlightSearchDynamicComponent {

`withStorageSync` adds automatic or manual synchronization with Web Storage (`localstorage`/`sessionstorage`).

> [!WARNING]
> [!WARNING]
> As Web Storage only works in browser environments it will fallback to a stub implementation on server environments.
Example:
Expand Down Expand Up @@ -434,13 +434,15 @@ To ensure stability, we clone these internal types and run integration tests for

### I have an idea for a new extension, can I contribute?

Yes, please! We are always looking for new ideas and contributions.
Yes, please! We are always looking for new ideas and contributions.

Since we don't want to bloat the library, we are very selective about new features. You also have to provide the following:
- Good test coverage so that we can update it properly and don't have to call you 😉.
- A use case showing the feature in action in the demo app of the repository.
- An entry to the README.md.

This project uses [pnpm](https://pnpm.io/) to manage dependencies and run tasks (for local development and CI).

### I require a feature that is not available in a lower version. What should I do?

Please create an issue. Very likely, we are able to cherry-pick the feature into the lower version.
Expand Down
1 change: 1 addition & 0 deletions nx.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"$schema": "./node_modules/nx/schemas/nx-schema.json",
"packageManager": "pnpm",
"targetDefaults": {
"build": {
"cache": true,
Expand Down
10 changes: 7 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,15 @@
"version": "0.0.0",
"license": "MIT",
"scripts": {
"start": "npx nx serve demo",
"build:all": "npx nx run-many --targets=build",
"verify:all": "npx nx run-many --targets=lint,test,build"
"start": "nx serve demo",
"build:all": "nx run-many --targets=build",
"verify:all": "nx run-many --targets=lint,test,build"
},
"private": true,
"engines": {
"node": ">=18",
"pnpm": "9"
},
"dependencies": {
"@angular-architects/paper-design": "^1.0.3",
"@angular/animations": "18.1.1",
Expand Down
Loading

0 comments on commit c24cba8

Please sign in to comment.