Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Contributing markdown has npm commands #338

Closed
jdegand opened this issue Jul 16, 2024 · 2 comments
Closed

[Bug]: Contributing markdown has npm commands #338

jdegand opened this issue Jul 16, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@jdegand
Copy link
Contributor

jdegand commented Jul 16, 2024

Relevant scope

angular application

Description

Setup, Development, and Build have npm commands that haven't been converted to appropriate yarn or nx commands.

Do you want to contribute with a pull request?

No

@jdegand jdegand added the bug Something isn't working label Jul 16, 2024
@ajitzero
Copy link
Contributor

Those commands are correct. They are just aliases to the correct Nx commands. You can see this in the package.json file.

"scripts": {
"prepare": "husky install",
"start": "nx serve angular-hub",
"build": "nx build angular-hub"
},

This is common practice so we don't need to memorize commands and stick to npm run build instead of nx build <app name>.

@jdegand
Copy link
Contributor Author

jdegand commented Jul 16, 2024

Ok.

@jdegand jdegand closed this as completed Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants