This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(tooltip): update position dynamically #3435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisirhc
force-pushed
the
feature/update-tooltip-position
branch
from
c8cde43 to
3b99f69
Compare
chrisirhc
added a commit
to chrisirhc/angular-ui-bootstrap
that referenced
this pull request
Mar 25, 2015
Reposition on each digest, this ensures that the tooltip is always positioned correctly no matter how its content changes. Fixes angular-ui#96 Fixes angular-ui#1109 Closes angular-ui#2816 Closes angular-ui#3435
This was referenced Mar 25, 2015
Closed
|
Yuck...this will likely be pretty unperformant I think. We can revisit this though after releasing 0.13 and seeing what we can do to improve the performance. LGTM for now. |
|
Yep indeed. There could be some optimizations to be made but I think it should be okay for now unless users of the directive have a lot of open tooltips at the same time. |
|
@RobJacobs unfortunately, this won't resolve #375 . That issue requires changes to the way |
Reposition on each digest, this ensures that the tooltip is always positioned correctly no matter how its content changes. Fixes angular-ui#96 Fixes angular-ui#1109 Closes angular-ui#2816 Closes angular-ui#3435
chrisirhc
force-pushed
the
feature/update-tooltip-position
branch
from
3b99f69 to
853fa45
Compare
|
is overflowing window borders issue is fixed? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reposition on each digest, this ensures that the tooltip is always positioned
correctly no matter how its content changes.
Fixes #96
Fixes #1109
Closes #2816
Prerequisite of #1848