This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(modal): defer promise resolution until animation starts #3806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm.. testing this might be quite challenging. Perhaps add a test that the promises are resolved after the animation has ended? |
|
The promises do not resolve before the animation has ended - they just resolve after the animation starts. |
- Defer resolution of modalInstance promise until the animation cycle starts
|
I added tests for this case and rebased |
chrisirhc
added a commit
to chrisirhc/angular-ui-bootstrap
that referenced
this pull request
Jul 4, 2015
- supports Angular 1.4 Fixes angular-ui#3787 Fixes angular-ui#3806 Closes angular-ui#3888
chrisirhc
added a commit
to chrisirhc/angular-ui-bootstrap
that referenced
this pull request
Jul 4, 2015
- supports Angular 1.4 Fixes angular-ui#3787 Fixes angular-ui#3806 Fixes angular-ui#3873 Closes angular-ui#3888
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the promise resolution completes before the animation cycle starts, so it is possible for DOM elements to become stranded if it is desired for the $scope passed in to be destroyed.
Plunker of fix in action here.
Fixes #3787