This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(datepicker): add uib- prefix #4509
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleycho
force-pushed
the
feat/datepicker-rename
branch
3 times, most recently
from
cdc509e
to
cc3ccb7
Compare
wesleycho
force-pushed
the
feat/datepicker-rename
branch
from
cc3ccb7
to
bed9e0b
Compare
wesleycho
force-pushed
the
feat/datepicker-rename
branch
from
bed9e0b
to
9a76141
Compare
|
This PR is good for review now. |
| function(scope, element, attrs, $compile, $parse, $document, $rootScope, $position, dateFilter, dateParser, datepickerPopupConfig, $timeout) { | ||
| var self = this; | ||
| var cache = {}, | ||
| isHtml5DateInput = false; |
There was a problem hiding this comment.
is this missing a var for declaration?
wesleycho
force-pushed
the
feat/datepicker-rename
branch
from
9a76141
to
035c0e6
Compare
|
This is a breaking change: |
|
@llafuente, good catch. Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might need assistance here, but here's what I have - I refactored the linking functions into controllers so the code can be reused between the deprecated and new prefixed directives.