Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix(carousel): reset $currentTransition when no slides #4532

Closed

Conversation

wesleycho
Copy link
Contributor

  • Reset $currentTransition when there are no slides

Here is a Plunker with the fix in action (as well as fixes to user error).

This fixes #4390.

- Reset `$currentTransition` when there are no slides
@Foxandxss
Copy link
Contributor

When creating a Plunker, please add instructions of how to see it working. If I understood correctly, I need to delete all slides and add new ones, but I don't see how to do that in the plunker.

@wesleycho
Copy link
Contributor Author

The Plunker is resetting it at a setTimeout of 5000ms, which is coincidentally when the animation starts, which triggers the bug in the original Plunker in the referenced issue

@Foxandxss
Copy link
Contributor

I see. After some seconds (before doing the first change) it does a weird animation thing. Do you see that? (Chrome).

@wesleycho
Copy link
Contributor Author

Yep, that will be hard to fix I think - there is another issue open currently with the 0.14 milestone on a weird animation problem when adding a new slide though, may be slightly related

@Foxandxss
Copy link
Contributor

Alright then.

@wesleycho wesleycho closed this in 0b3d5bd Oct 3, 2015
@wesleycho wesleycho deleted the fix/carousel-transition branch October 3, 2015 21:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Carousel - empty slide list
2 participants