Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

angular-bootstrap version 0.14.x and tooltip-append-to-body="true" causes vertical scroll bar to flicker. #4613

Closed
shenlong opened this issue Oct 14, 2015 · 17 comments

Comments

@shenlong
Copy link

Hi Guys, I have the scroll bar appearing and changing size issue for this new release angular-bootstrap version 0.14.2 when tooltip-append-to-body="true".

Plunker as follows:
http://plnkr.co/edit/HxTIllqhV0QSmDoZGtB3?p=preview

@icfantv
Copy link
Contributor

icfantv commented Oct 14, 2015

Closing as a duplicate of #4458. Please search both open and closed issues before opening one. For my part, I have been unable to reproduce this.

@icfantv icfantv closed this as completed Oct 14, 2015
@shenlong
Copy link
Author

Hi @icfantv,
In the plunker i provided, i have tested with 0.14.2 and it seems to affect only when tooltip-append-to-body="true", so i am not really sure if it is a duplicate.

@icfantv
Copy link
Contributor

icfantv commented Oct 14, 2015

I still can't reproduce this. What platform/browser are you using?

@RobJacobs
Copy link
Contributor

I don't see the problem either? FYI, the example in your plunk, tooltip-append-to-body is set to false. I set that value to true and still didn't see the issue.

@shenlong
Copy link
Author

I updated the plunker. you need to:

  1. resize your vertical height to a small size window
  2. make sure you see the vertical scroll.
  3. mouse over and out and over.

Did you see the scroll bar jumping and the tooltip appears?
image

I am using Google Chrome version 45.0 with Windows 10 x64.

@icfantv
Copy link
Contributor

icfantv commented Oct 14, 2015

Ok, I'm on a mac which hides the scrollbar after like 500ms which is why this is so hard to reproduce. I can see it, but it's VERY hard to reproduce on a mac.

Additionally, this IS a duplicate of #4458 so leaving as closed.

@RobJacobs
Copy link
Contributor

@shenlong @icfantv I believe this is similar to #4458 with the fix being add top: -9999px and left: -9999px to the tooltip template style here. Here is an updated plunk with those suggested changes. Here is issue #4458's plunk with the same changes.

@icfantv
Copy link
Contributor

icfantv commented Oct 14, 2015

@RobJacobs, let's run that by @wesleycho and see if he's good with that. TBH though, It smells like a hack to me unless this is an industry "standard."

@wesleycho
Copy link
Contributor

It's a hack, but a well-known one...I don't have a huge opinion on it, and would be fine with it.

@RobJacobs
Copy link
Contributor

It's documented in ng-hide and TWBS uses it for the modal-scrollbar-measure class

@wesleycho
Copy link
Contributor

Sounds good to me then

@icfantv
Copy link
Contributor

icfantv commented Oct 14, 2015

Works for me as well. @RobJacobs you wanna make a PR?

@shenlong
Copy link
Author

Hi guys, thanks for the workaround. It looks good.

Background information: This existing issue is prominent when I am using ng-view with static headers. The vertical scrollbar only appears under the ng-view for overflow content. but having this bug will show another vertical scrollbar that appears at the header and since I did not style a slim scrollbar for the page, the re-flow of contents to accommodate 2 scrollbars width makes a annoying flickering.

@icfantv
Copy link
Contributor

icfantv commented Oct 15, 2015

@shenlong, just a head's up that we're committing a fix for this. The PR is #4623 and should be merged either tonight or tomorrow. So you won't necessarily have to implement a workaround on your end.

@shenlong
Copy link
Author

Hi icfantv,

Thanks for the heads up. I will prepare my bower for it! Hopefully get it asap as i need to implement the fix on my production site! Cheers!

@icfantv
Copy link
Contributor

icfantv commented Oct 15, 2015

@shenlong, you want npm and grunt, not bower. In fact, don't use Bower anymore - it's kind of dying off. Check out that git revision, run an npm install and then grunt and it will put everything in the dist folder.

Looks like that PR was merged so you should be good to go.

@shenlong
Copy link
Author

Hi @icfantv , my production server automatically bowers updates the "bower_component" folder. A gulp script then minifies and modify the link with CDN for production releases.

Will there be official version release for this?
Just curious how frequent do you update the release here: https://github.com/angular-ui/bootstrap/releases and the https://github.com/angular-ui/bootstrap-bower

Even though PR is merged, I need version tracking for third party framework.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants