-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Popover closes unexpectedly #5347
Comments
@BartoGabriel, please do not use the issues forum for support-related requests. Rather, please follow the instructions here as support-related questions are best served by and for the community. The issues forum is reserved for bugs. Thanks. The problem is that you are using a datepicker inside a popover and you've specified |
@icfantv It is not normal behavior. For example if you select the date from 01/03/2016 three times, the component is closed. |
While I agree that this is not normal behavior, it does not change the fact that you're not using the combination of the two correctly. Because of this latter statement, I'm not sure it makes any sense for the developers to spend time investigating why this is occurring. Investigation into issues can be quite time consuming and we would like to reserve it for issues that are more clearly library bugs. I'm happy to reopen this but it's probably going to be a very low priority. What are your thoughts? |
I spoke with the dev team and we think we believe we have a relatively easy fix which would involve stopping event propagation on the buttons in the datepicker so that events don't leak out from the component (making it isolated). That said, you still want to change your trigger on the popover because even if we do that, you're still going to run into issues with the buttons that lie outside the popover boundaries. |
This is looking like a pretty big change since nearly all the templates will need to change as well as the datepicker code as well. This is not trivial. |
I agree that the priority should be low, and the error is not urgent. I do not think it worthwhile to make many changes just for this error. On the other hand, it does not take into account the limits of the popover as you say. For example, if you click on the June 2, it has the same behavior as clicking on a date which is within the borders of popover. |
I'm going to schedule this for 1.2 - I think this is pretty important to fix, but one can temporarily fix this by wrapping the datepicker usage like this <div ng-click="$event.stopPropagation()">
<input uib-datepicker-popup ng-model="foo">
</div> |
@wesleycho thank you very much. Following the example in case anyone ever need with the current version. |
Example:
http://plnkr.co/edit/dMWd7KRHjaoOZWXyYvE5?p=preview
Reference: #5305 (comment)
The text was updated successfully, but these errors were encountered: