Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix(tooltip): ensure tooltip custom CSS is imported with webpack #5552

Closed
wants to merge 1 commit into from
Closed

fix(tooltip): ensure tooltip custom CSS is imported with webpack #5552

wants to merge 1 commit into from

Conversation

mattlewis92
Copy link
Contributor

No description provided.

@wesleycho
Copy link
Contributor

Does this play nice with Browserify?

@mattlewis92
Copy link
Contributor Author

If you have the right plugin installed it should, it's how the carousel, typeahead etc already function i.e they already require css files

On 29 Feb 2016, at 20:46, Wesley Cho notifications@github.com wrote:

Does this play nice with Browserify?


Reply to this email directly or view it on GitHub.

@wesleycho
Copy link
Contributor

Looks like we already do this in the other components, this just got missed.

LGTM

@wesleycho wesleycho added this to the 1.2.2 milestone Feb 29, 2016
@wesleycho wesleycho closed this in c8922a2 Feb 29, 2016
@mattlewis92
Copy link
Contributor Author

Awesome, thanks!

On 29 Feb 2016, at 22:27, Wesley Cho notifications@github.com wrote:

Closed #5552 via c8922a2.


Reply to this email directly or view it on GitHub.

@RobJacobs
Copy link
Contributor

@wesleycho @mattlewis92 Looks like this is missing for the position.css in the position index.js too. Popover index.js has a require on tooltip.js, is tooltip.css needed there as well?

@Foxandxss
Copy link
Contributor

If you require an index.js, all the requires inside are loaded as well.

@mattlewis92 mattlewis92 deleted the mattlewis92-tooltip-webpack-fix branch February 29, 2016 22:43
@wesleycho
Copy link
Contributor

Position needs it still - not sure if we're missing it on any others.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants