Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pinned column doesn't align on scroll with the rest of the grid #3022

Closed
roedit opened this issue Mar 16, 2015 · 2 comments · Fixed by #6612
Closed

Pinned column doesn't align on scroll with the rest of the grid #3022

roedit opened this issue Mar 16, 2015 · 2 comments · Fixed by #6612
Assignees
@swalters
Labels
type: bug
Milestone
3.1

Comments

@roedit
Copy link

roedit commented Mar 16, 2015

Scrolling to the bottom of the grid there's a difference between the pinned column and the rest of the grid .
Here is the plunker for it :
http://plnkr.co/edit/s36dFIFuqwsOHG1NnhVl?p=preview
And also a print for it:
gridissue
@PaulL1 PaulL1 added this to the 3.0 milestone Mar 26, 2015
@PaulL1
Copy link
Contributor

PaulL1 commented Mar 28, 2015

@swalters: are you looking at this with your scrolling changes? Assigning to you just in case you are. :-)

@PaulL1 PaulL1 modified the milestones: 3.1, 3.0 Apr 16, 2015
@PaulL1
Copy link
Contributor

PaulL1 commented Apr 16, 2015

This only happens where the body has a scrollbar, the pinned container doesn't, and the scroll event is over the pinned container. The pinned container goes all the way to it's bottom, the body doesn't quite reach the bottom. Scrolling over the body instead will get you all the way to the bottom.

DanielDiTommaso pushed a commit to DanielDiTommaso/ui-grid that referenced this issue Mar 19, 2018
fix(GridRenderContainer.js): needsHScrollbarPlaceholder accounts for …
52ce405 
…WHEN_NEEDED

Added logic to needsHScrollbarPlaceholder to account for left/right rendercontainers as well as
handle case when gridOption enableHorizontalScrollbar is set to WHEN_NEEDED.

fix angular-ui#6280, fix angular-ui#5812, fix angular-ui#5760, fix angular-ui#6590, fix angular-ui#6572, fix angular-ui#6528, fix angular-ui#4251, fix angular-ui#3022
@DanielDiTommaso DanielDiTommaso mentioned this issue Mar 19, 2018
Merged
mportuga pushed a commit that referenced this issue Mar 19, 2018
@mportuga
fix(GridRenderContainer.js): needsHScrollbarPlaceholder accounts for …
403bf3e 
…WHEN_NEEDED

Added logic to needsHScrollbarPlaceholder to account for left/right rendercontainers as well as
handle case when gridOption enableHorizontalScrollbar is set to WHEN_NEEDED.

fix #6280, fix #5812, fix #5760, fix #6590, fix #6572, fix #6528, fix #4251, fix #3022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swalters swalters

Labels
type: bug
Projects
None yet
Milestone
3.1
Development

Successfully merging a pull request may close this issue.

fix(WHEN_NEEDED): needsHScrollbarPlaceholder accounts for WHEN_NEEDED DanielDiTommaso/ui-grid
3 participants
@swalters @PaulL1 @roedit