-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GridOptions.minimumColumnSize is not taken into account #3941
Comments
+1 on this ... |
It seems the actual setting is It seems that the code and the docs need to be updated in order to fix this. |
The fix can't be to remove the option, right? I assumed the purpose of this option was to avoid having to specify a minWidth or width on every single column individually (annoying if you have lots of columns). |
+1 |
…ot present GridOptions.minimumColumnSize is now used as the default minWidth for all colmumns when it is provided and it is valid. However, minWidth will still take precedence over minimumColumnSize if provided. fix #3941
…ot present GridOptions.minimumColumnSize is now used as the default minWidth for all colmumns when it is provided and it is valid. However, minWidth will still take precedence over minimumColumnSize if provided. fix #3941
Looking at the API docs for Grid options (http://ui-grid.info/docs/#/api/ui.grid.class:GridOptions) there is an option of minimumColumnSize. This doesn't seem to be taken into account.
Searching through the code base for "minimumColumnSize" yields no actual logic. I think it soulld be taken into account in the updateColumnWidths method in GridRenderContainer: https://github.com/angular-ui/ng-grid/blob/master/src/js/core/factories/GridRenderContainer.js#L595
A plunkr example:
http://plnkr.co/edit/zpOUTXlSXCvbPbwOu0yZ
The text was updated successfully, but these errors were encountered: