Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GridOptions.minimumColumnSize is not taken into account #3941

Closed
mearing opened this issue Jul 6, 2015 · 4 comments · Fixed by #6619
Closed

GridOptions.minimumColumnSize is not taken into account #3941

mearing opened this issue Jul 6, 2015 · 4 comments · Fixed by #6619

Comments

@mearing
Copy link

mearing commented Jul 6, 2015

Looking at the API docs for Grid options (http://ui-grid.info/docs/#/api/ui.grid.class:GridOptions) there is an option of minimumColumnSize. This doesn't seem to be taken into account.

Searching through the code base for "minimumColumnSize" yields no actual logic. I think it soulld be taken into account in the updateColumnWidths method in GridRenderContainer: https://github.com/angular-ui/ng-grid/blob/master/src/js/core/factories/GridRenderContainer.js#L595

A plunkr example:
http://plnkr.co/edit/zpOUTXlSXCvbPbwOu0yZ

@PaulL1 PaulL1 self-assigned this Jul 19, 2015
@veljkopopovic
Copy link

+1 on this ...

@JLLeitschuh
Copy link
Contributor

It seems the actual setting is minWidth
http://ui-grid.info/docs/#/api/ui.grid.class:GridOptions.columnDef

It seems that the code and the docs need to be updated in order to fix this.

@achronicity
Copy link

The fix can't be to remove the option, right? I assumed the purpose of this option was to avoid having to specify a minWidth or width on every single column individually (annoying if you have lots of columns).

@betsydupuis
Copy link

+1

mportuga pushed a commit that referenced this issue Mar 21, 2018
…ot present

GridOptions.minimumColumnSize is now used as the default minWidth for all colmumns when it is
provided and it is valid. However, minWidth will still take precedence over minimumColumnSize if
provided.

fix #3941
mportuga pushed a commit that referenced this issue Mar 21, 2018
…ot present

GridOptions.minimumColumnSize is now used as the default minWidth for all colmumns when it is
provided and it is valid. However, minWidth will still take precedence over minimumColumnSize if
provided.

fix #3941
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants