Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less-than filter excludes all rows when erased manually and another filter is still applied on the same column #4055

Closed
mage-eag opened this issue Jul 27, 2015 · 2 comments

Comments

@mage-eag
Copy link
Contributor

This behaviour is reproducible on the filtering tutorial :

  1. Filter the "Age" column on values greater than 1
  2. Filter the same column on values lesser than 30
  3. Erase the "less than" field manually (not using the dedicated button)

Result : all the rows are now filtered out.

The reason seems to be that the term value is not reset to null or undefined when the corresponding field is erased by hand, but is still taken into account because another filter on the same column still has a "valid" term value.

I managed to fix this by testing for an empty string when number values are involved, but I'm not sure at all whether this is a convenient solution, or if this could bring unwanted side-effects.

Please let me know what are your thoughts about it, and whether I can create a PR with the possible fix.

@alam123
Copy link
Contributor

alam123 commented Jul 27, 2015

I have already raised this issue and submitted a pull request.

#3923
#4012

@mage-eag
Copy link
Contributor Author

Oops sorry, I had seen your PR but funnily did not make the connection .. thanks, will start using it right away :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants