-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid does not update select all state when data changes. #6033
Comments
Just had a brief look at the code and it seems the selection module is not listening for any changes in the underlying data. Therefore once the new row is added the selection model is outdated until a new selection takes place. I have just recently started using this grid and its awesome!! I will look to see if there is an event that can be listened to and then the selection model will need to listen to it. Very keen to contribute a fix as I have found this grid extremely useful. I am however a bit of a newbie and not sure of the process to follow. Anyone can point me in the right direction? |
…ctAll" header check is not in sync with the actual selection state of the row. Perhaps this is not the best solution because it couples the selection directive the ui-grid directive. However, this does illustrate a possible solution.
I created a pull-request with a possible solution to this issue. |
…der check is not in sync with the actual selection state of the row. Perhaps this is not the best solution because it couples the selection directive the ui-grid directive. However, this does illustrate a possible solution.
…ctAll" header check is not in sync with the actual selection state of the row. Perhaps this is not the best solution because it couples the selection directive the ui-grid directive. However, this does illustrate a possible solution.
I have a ui-grid with multi-select enabled. Everything works fine, except when the data changes, the "select" column in the header does not properly show the state of the grid. I've created a simple example in plunker that illustrates the issue. To reproduce:
If you click on any of the rows at this point, the code is smart enough to properly set the header check value. It seems to me that as the data for the grid changes, the status of the "all selected" flag should be re-evaluated.
This sample code was created by forking the "112 Add/Delete/Swap Data" tutorial code and just adding multi-select to the grid.
The text was updated successfully, but these errors were encountered: