Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell remained focus causing scrolled up #6591

Closed
BMK91 opened this issue Mar 7, 2018 · 6 comments
Closed

Cell remained focus causing scrolled up #6591

BMK91 opened this issue Mar 7, 2018 · 6 comments

Comments

@BMK91
Copy link

BMK91 commented Mar 7, 2018

Dear,

While I'm using ui-grid-edit, ui-grid-cellNav with enableCellEditOnFocus: true to use single click edit, I encounter an issue of scrolling up.

Please check the following plunker.
http://plnkr.co/edit/chouuTGlXHuWtQXk2mw1?p=preview

Steps:
Click on the first editable cell, then scroll-down.

Thanks.

@mportuga
Copy link
Member

What is the issue? And was it specific to any browser or OS?

@BMK91
Copy link
Author

BMK91 commented Mar 13, 2018

Please read the question properly, I've given plunker with steps provided.

@mportuga
Copy link
Member

mportuga commented Mar 22, 2018

I am sorry, but I am struggling to understand what you mean by "causing scrolled up", I tried clicking the first editable cell and scrolling down and nothing of note appeared to happen.

As a note, I tried it on Mac Chrome, Firefox and Safari.

@BMK91
Copy link
Author

BMK91 commented Mar 28, 2018

See this video before closing.
https://vimeo.com/262246299

@mportuga mportuga reopened this Mar 29, 2018
@m4m4m4
Copy link
Contributor

m4m4m4 commented Apr 23, 2018

I get this behavior too, if I click a cell at the bottom of what is rendered and then scroll upwards making the cell below the rendered rows, the grid scrolls up and sometimes multiple times which is really confusing.
I think it has to do with this commit letting through events that are undefined, previously it only triggered on click and keydowns: cc8144c

@m4m4m4
Copy link
Contributor

m4m4m4 commented Apr 23, 2018

I should probably do a rebase by now.. The following commit reverts the behavior to how it was before where "beginEdit" function only listens to click and keydown events. But now it also accepts a null object which makes it possible to trigger a cell edit from the api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants