Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui-grid.ttf is not a valid font file #6809

Open
ESPNSTI opened this issue Jul 25, 2018 · 6 comments · Fixed by #6820
Open

ui-grid.ttf is not a valid font file #6809

ESPNSTI opened this issue Jul 25, 2018 · 6 comments · Fixed by #6820

Comments

@ESPNSTI
Copy link

ESPNSTI commented Jul 25, 2018

In 4.6.2, when double clicking on src/font/ui-grid.ttf in Windows, it shows a dialog that indicates "The requested file ...\ui-grid.ttf is not a valid font file".

Looking at a diff of the file between commit 8096ed0 and ec13255, it looks like a "0D 0A" was changed to just a "0A", so it appears that a CRLF to LF conversion was done.

The ui-grid.eot file seems to also have gone through a CRLF to LF conversion.

@msaikaushik
Copy link
Contributor

@ESPNSTI hi, can i take this issue?

@msaikaushik
Copy link
Contributor

shall i replace the older working files with the present ones?

@ESPNSTI
Copy link
Author

ESPNSTI commented Aug 1, 2018

Yes, go ahead.

@msaikaushik
Copy link
Contributor

i have done a PR

mportuga pushed a commit that referenced this issue Aug 4, 2018
defields923 pushed a commit to defields923/ui-grid that referenced this issue Oct 30, 2018
@nickxbs
Copy link

nickxbs commented Nov 8, 2019

Hello, i think that the same error was introduced with the commit 7f2d079

@jmuker
Copy link

jmuker commented Aug 4, 2021

This is still an issue in v4.10.3, when can we expect to see this fixed in a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants